Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-246] 일반랭커 트로피에 티어 표시 제거 #999

Merged
merged 3 commits into from
Sep 13, 2023
Merged

[GGFE-246] 일반랭커 트로피에 티어 표시 제거 #999

merged 3 commits into from
Sep 13, 2023

Conversation

parksangmin1543
Copy link
Contributor

@parksangmin1543 parksangmin1543 commented Sep 11, 2023 •
edited
Loading

📌 개요

  • 일반랭커인경우 티어표시되는 문제 수정

💻 작업사항

  • 일반랭커인경우 (트로피에) 티어표시가 안되게 수정했습니다.
  • 이름이 너무 길경우 가운데 정렬이 안되는 부분 수정했습니다.

✅ 변경로직

@yoouyeon yoouyeon changed the title [GGFE-246] 일반랭커 티어표시 안함 [GGFE-246] 일반랭커 트로피에 티어 표시 제거 Sep 11, 2023
PHJoon
PHJoon approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@PHJoon PHJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 이제 일반 랭커는 티어이미지 안보이네요! 고생하셨습니다!! 👍

yoouyeon
yoouyeon approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 이런 이슈도 있었군요... 모르고 있었네요;;
이제 티어 이미지 안뜨는 것 확인했습니다! 수고하셨습니다!!! 😆👍

components/rank/topRank/RankListItemMain.tsx Outdated
styleName={'ranktier'}
size={10}
/>
{Mode == 'RANK' && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 비교 연산자 === 으로 수정 부탁드립니다!!

hyobb109
hyobb109 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@hyobb109 hyobb109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정사항 모두 확인했습니다! 고생하셨습니다👏

@parksangmin1543 parksangmin1543 merged commit b90dbbe into main Sep 13, 2023
@PHJoon PHJoon deleted the GGFE-246-일반랭커-티어id branch October 30, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyobb109 hyobb109 hyobb109 approved these changes

@PHJoon PHJoon PHJoon approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@parksangmin1543 parksangmin1543

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parksangmin1543 @yoouyeon @PHJoon @hyobb109