Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GGFE-227] Megaphone-storybook 추가 #973

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented Sep 4, 2023

📌 개요

  • Megaphone-storybook 추가

💻 작업사항

  • Megaphone-storybook 추가했습니다.

✅ 변경로직

@PHJoon PHJoon self-assigned this Sep 4, 2023
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당 👍

Comment on lines 14 to 16
export const Empty: Story = {
args: {},
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 스토리 이름이 Empty인데, 컴포넌트 안에서 api 호출을 하고 있어서 (지금은 안되지만 ㅎㅎㅜ) 서버 고쳐지면 실제로 등록된 확성기 내용이 나올 것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default로 바꿨습니다! 👍

Copy link
Member

@hyobb109 hyobb109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 수고하셨습니다!👍

Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가한 사항확인했습니다!

@yoouyeon yoouyeon merged commit 386b088 into main Sep 5, 2023
@hyobb109 hyobb109 deleted the GGFE-227-스토리북-확성기 branch October 30, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants