Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-212] 코인팝콘 에러 수정 #960

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[GGFE-212] 코인팝콘 에러 수정 #960

merged 1 commit into from
Aug 25, 2023

Conversation

parksangmin1543
Copy link
Contributor

📌 개요

  • 코인팝콘 에러부분 수정

💻 작업사항

  • MouseEvent를 react로 사용하고 있어서 에러가 발생해서 수정했습니다.

✅ 변경로직

@PHJoon PHJoon changed the title [Bug] [GGFE-212] 코인팝콘 에러 수정 [GGFE-212] 코인팝콘 에러 수정 Aug 25, 2023
PHJoon
PHJoon approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@PHJoon PHJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다!! React.mouseEvent와 mouseEvent 사용에 있어 차이가 있군요. 고생하셨습니다!! 👍👍

yoouyeon
yoouyeon approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document.addEventListener에 전달되는 함수라 React.MouseEvent 타입이 아닌거였군요 🥲 수고하셨습니다!

@parksangmin1543 parksangmin1543 merged commit e73efaf into main Aug 25, 2023
@PHJoon PHJoon deleted the GGFE-212-코인팝콘버그수정 branch September 4, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PHJoon PHJoon PHJoon approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@parksangmin1543 parksangmin1543

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parksangmin1543 @yoouyeon @PHJoon