-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GGFE-189] stylelint scss rule 추가 #946
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
와 규칙을 일일이 다 설정해줘야 하는 것이었네요...??!
규칙 잘 적용되는 것 확인했습니다!!
설정해야 할 내용이 많은데 수고 정말 많으셨어요!! 😆👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint
처럼 커밋 시에 자동으로 실행시키려면 이렇게 lint-staged
항목에 추가해두면
"lint-staged": {
"*.{ts,tsx,scss,md}": "prettier --write",
"*.{ts,tsx}": "eslint --cache --fix",
"styles/**/*.{scss}": "stylelint --fix"
}
husky pre-commit
hook에서 lint-staged
실행시키면서 같이 stylelint
까지 실행시키게 됩니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 저렇게 해도 안되길래 직접해야되는줄 알았는데 제가 수정한 scss 파일이 없어서 저렇게 해도 실행이 안됐던거네요.. 😭 감사합니다!
lint-staged에 추가해놨습니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
와 설정할 것이 엄청 많았네요..!! 적용 잘 되고 lint-staged에 추가된 것도 확인했습니다! 정말 고생 많으셨어요!👍👍
📌 개요
💻 작업사항
npx stylelint "styles/**/*.scss"
npx stylelint "styles/**/*.scss" --fix
✅ 변경로직