[GGFE-173] 보관함 프로필 이미지띠 배경색 모달 #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHJoon
approved these changes
Aug 20, 2023
styles/common.scss
Outdated
Comment on lines
85
to
100
| $profile-background1: linear-gradient(to bottom, #ef629f, #eecda3); | ||
| $profile-background2: linear-gradient(to bottom, #acb6e5, #86fde8); | ||
| $profile-background3: linear-gradient(to bottom, #00416a, #e4e5e6); | ||
| $profile-background4: linear-gradient(to top, #ffe259, #ffa751); | ||
| $profile-background5: linear-gradient(to bottom, #215f00, #e4e4d9); | ||
| $profile-background6: linear-gradient(to top, #3d7eaa, #ffe47a); | ||
| $profile-background7: linear-gradient(to top, #dc2424, #4a569d); | ||
| $profile-background8: linear-gradient(to bottom, #1cd8d2, #93edc7); | ||
| $profile-background9: linear-gradient(to bottom, #757f9a, #d7dde8); | ||
| $profile-background10: linear-gradient(to bottom, #870000, #190a05); | ||
| $profile-background11: linear-gradient(to bottom, #2980b9, #6dd5fa, #ffffff); | ||
| $profile-background12: linear-gradient(to top, #9cecfb, #65c7f7, #0052d4); | ||
| $profile-background13: linear-gradient(to top, #77a1d3, #79cbca, #e684ae); | ||
| $profile-background14: linear-gradient(to top, #a770ef, #cf8bf3, #fdb99b); | ||
| $profile-background15: linear-gradient(to top, #bbd2c5, #536976, #292e49); | ||
| $profile-background16: linear-gradient(to top, #c6ffdd, #fbd786, #f7797d); |
There was a problem hiding this comment.
배경색도 그렇고 프로필 테두리색도 색 이름이 존재한다면 변수명에 포함시켜야 나중에 관리하기 더 쉬울 것 같아요. 색 이름이 없다면 간단하게라도 포함된 색들로 이름 만들어서 포함시켜주면 한번에 색상 파악하기 좋을거 같습니다!
There was a problem hiding this comment.
넵 안그래도 이름 바꿔야겠다고 생각했어요😂 수정하겠습니다!
|
우선 배경색, 이미지띠 색 변수명을 색상을 알아볼 수 있도록 수정했습니다! 또추후에 티어 이미지 추가되면 티어가 잘 보이도록 몇몇 색상 변경할 수도 있을 것 같습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
✅ 변경로직