Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into GGFE-156-상점-프로필-사진-변경-모달
parksangmin1543
approved these changes
Aug 17, 2023
PHJoon
approved these changes
Aug 18, 2023
Comment on lines
+85
to
+89
| <input | ||
| type='file' | ||
| accept='image/jpeg' | ||
| style={{ display: 'none' }} | ||
| onChange={uploadImg} |
There was a problem hiding this comment.
어라 관리자에서는 이미지 확장자 상관 없이 받나요...?
관리자에서 유저 상세정보 수정 api 명세에 보니까 fileType: Only .JPEG 라고 적혀있더라구요..!
지금 다시 보니까 관리자에서 이미지를 입력받는 input 태그에서는 따로 accept 속성으로 파일의 확장자를 지정해두진 않았는데, 파일을 전송할때에는 jpeg 타입이라고 명시해서 보내주고 있었습니다.. 🤔
formData.append('imgData', new Blob([imgData], { type: 'image/jpeg' }));png 같은 다른 확장자를 입력받는 경우에도 데이터 타입만 jpeg로 표시해서 보내주면 문제없이 되는건지는 다시 확인해봐야 할 것 같아요 🤔
There was a problem hiding this comment.
일단 이 PR은 머지하고 이후 확장자 관련해서 업데이트 해야 할 내용이 있으면 추가해서 다시 PR 올릴게요!
hyobb109
approved these changes
Aug 18, 2023
mike2ox
reviewed
Aug 18, 2023
components/modal/ModalButton.tsx
Outdated
| return ( | ||
| <div className={styles[style]}> | ||
| <input onClick={() => onClick()} type='button' value={value} /> | ||
| <input | ||
| onClick={() => onClick()} |
There was a problem hiding this comment.
Suggested change
| onClick={() => onClick()} | |
| onClick={onClick} |
어차피 onClick을 IoC로 인해 주입되고 있어서 바로 넣어도 됩니다
There was a problem hiding this comment.
엇 그러네요... 왜 저렇게 했지... 수정했습니다!!
IoC는... 아직 정확히는 잘 모르겠네요 😵💫 좀 더 공부해볼게요! 감사합니당 😆
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
✅ 변경로직