Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GGFE-179] tier 색상부분 수정 #933

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

parksangmin1543
Copy link
Contributor

📌 개요

  • tier 배경 색상 변경

💻 작업사항

  • 배경 투명도를 내려서 가독성을 올렸습니다.
  • 넘버로 값을 받는 대신 스트링으로 받아서 무슨 색상인지 확인이 편하실것같습니다.

✅ 변경로직

@parksangmin1543 parksangmin1543 changed the title [refactor] [GGFE-179] tier 색상부분 수정 [GGFE-179] tier 색상부분 수정 Aug 14, 2023
@@ -128,7 +128,7 @@
font-size: $small-font;
align-items: center;
text-align: center;
background-color: #73cce4;
background-color: #8fc7fb;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

색상만 바뀌고 투명도 설정은 안 된 것 같아요! 제 노트북에선 여전히 잘 안보이네요ㅠ #8fc7fb9a; 정도로 투명도 높여주면 잘 보일 것 같습니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 확실히 알려주신대로 바꾸니까 더 잘보이네요. 추가적으로 무지개도 바뀠는데 확인부탁드립니다.

Copy link
Member

@hyobb109 hyobb109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다! 투명도 설정만 다시 해주시면 좋을 것 같아요! 고생하셨습니다👍

Copy link
Contributor

@PHJoon PHJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 셀렉터에서 string으로 인덱스 설정하니 가독성이 더 좋네요! 고생하셨습니다!! 👍

@parksangmin1543 parksangmin1543 merged commit 0fbd6c7 into main Aug 16, 2023
@PHJoon PHJoon deleted the GGFE-179-티어-색상-변경 branch September 4, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants