[GGFE-177] 관리자 거래내역 특정유저 조회 기능 #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyobb109
approved these changes
Aug 14, 2023
yoouyeon
reviewed
Aug 14, 2023
| }; | ||
|
|
||
| const profile10: Iprofile = { | ||
| profileId: 5, |
There was a problem hiding this comment.
여기 id가 중복된게 있어서 중복된 키 에러가 납니다!! 수정하면 좋을 것 같습니다!!
Comment on lines
61
to
64
| const res = await mockInstance.get( | ||
| `/admin/megaphones/history?intraId=${intraId}&page=${currentPage}&size=10` | ||
| ); | ||
| setIntraId(intraId); |
There was a problem hiding this comment.
여기 흐름이 잘 이해가 안가요! mockInstance에서 intraId를 사용하는데 왜 다시 setIntraId를 하게 되는건가요???
There was a problem hiding this comment.
관리자페이지 다른 곳에서 사용하는 것을 그대로 가져오면서 지우지 않은 것 같습니다. 없어도 되는 부분이라 삭제했습니다 👍👍
|
피드백 주신 id 키 수정, 필요없는 부분 삭제 수정했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
✅ 변경로직