Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GGFE-141] coin animation css #914

Merged
merged 11 commits into from
Aug 7, 2023
Merged

Conversation

parksangmin1543
Copy link
Contributor

@parksangmin1543 parksangmin1543 commented Aug 3, 2023

📌 개요

  • coin animation css 디자인 추가

💻 작업사항

  • coin modal추가
  • 출석, 랭크, 일반에 추가 했습니다.
  • 터지는 코인, 애니메이션 이후 자동 닫기기능 추가 예정입니다.
  • 출석, rank, normal mockapi 작업 마무리했습니다.
  • 출석시에 경험치모달과 코인모달이 뜨는걸 확인할수 있습니다. (변경을 원하시면 welcomemodal에서 openStatChangeModal -> openAttendanceCoin로 변경하시면 확인 가능합니다.)

✅ 변경로직

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 사용하지 않는 모달인가요?

Copy link
Member

@hyobb109 hyobb109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

애니메이션 멋지네요! 수고하셨습니다. 디자인은 나중에 간격이나 이미지들만 좀 더 깔끔하게 수정하면 괜찮을 것 같아요

Copy link
Contributor

@PHJoon PHJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

애니메이션 + 엮여있는 모달도 많아서 복잡한 작업하시느라 고생하셨습니다! 애니메이션 예쁘게 잘 나오네요! 게임 마친 경우는 테스트 못해봤는데 코드상으로는 잘 뜰거 같습니다. 출석 시에는 잘 나옵니다. 고생하셨습니다!! 👍

transform: translateY(-100%);
}

@for $i from 1 through 15 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css 반복문 쓰는법 배워갑니다 👍

@@ -87,6 +105,28 @@ const useSubmitModal = (currentGame: AfterGame) => {
});
};

const openNormalCoin = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아래 openRankCoin하고 똑같이 작동하는거 같은데 테스트용으로 만들어두신걸까요??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openNormalCoinnormalcoin state의 값으로 모달을 열어야 하고 openRankCoinrankcoin의 값으로 모달을 열어야 하기 때문에 따로 두신 것 같아요. 근데 openCoin 같은 이름으로 함수를 합치고 상황에 맞게 적절한 state를 파라미터로 넘길 수도 있을 것 같네요...


useAxiosResponse();
useGetUserSeason();
useSetAfterGameModal();
useLiveCheck(presentPath);
useAnnouncementCheck(presentPath);

useEffect(() => {
/* if (user.isAttended)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중에 api 연결되면 isAttended 값이 false일 때만 모달 띄우는 방식으로 가는 걸까요?

Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업하신 내용 확인했습니당 디자인은 계속 생각해보고 수정해봐야 할 것 같네요... 🥲 수고하셨습니다!!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 파일 왜인지 prettier가 동작하지 않은 것 같네요...?? Prettier 설정 한번 확인해보시면 좋을 것 같습니다

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

적용완료

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 파일도 prettier 적용이 안되어있습니다!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

적용완료

Comment on lines 12 to 23
const moneyamount = Array.from({ length: amount }).map((_, index) => {
const randomTilt = tilts[Math.floor(Math.random() * 3)];
const stackStyle = randomTilt === "none" ? styles.stack : styles.stackl;

return (
<div key={index} className={`${stackStyle} ${styles.fall}`}>
<svg className={`${styles.coin}`}>
<CoinIcon />
</svg>
</div>
);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저번에 코인 개수가 1개일 경우에는 좀 부족해보인다는 얘기가 있었던 것 같은데 일단은 코인 개수 그대로 보여주기로 한건가요???

Comment on lines 79 to 83
async function openChangeModal() {
openStatChangeModal();
await new Promise((resolve) => setTimeout(resolve, 2000)); // 2초 대기
openRankCoin();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statChangeModal이 뜨고 2초 뒤에 코인 모달이 뜨게 되는데 statChangeModal을 단 2초간만 볼 수 있게 되어서 (코인 모달을 닫게 되면 모든 모달이 닫히게 됨) 좀 불편할수도 있을 것 같아요...
statChangeModal을 계속 볼 수 있는 방법을 생각해봐야 할 것 같습니다..

Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

애니메이션만 처리하면 될 줄 알았는데 생각보다 연결된 부분이 많았네요ㅜㅜ 수고하셨습니다!!!!

@@ -26,10 +41,17 @@ const useGetUserSeason = () => {
type: 'setError',
});

useEffect(() => {
console.log(user.isAttended, presentPath === '/', isLogIn);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

콘솔 로그 삭제 부탁드립니다!

Comment on lines 42 to 45
/* async function openChangeModal() {
await new Promise((resolve) => setTimeout(resolve, 2000)); // 2초 대기
openStatChangeModal();
} */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 혹시 이제 안쓰는 부분이라면 삭제해주세요~!

@parksangmin1543 parksangmin1543 merged commit 074943b into main Aug 7, 2023
@PHJoon PHJoon deleted the GGFE-141-CoinAnimation-CSS branch September 4, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants