Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHJoon
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
나중에 선물받는 유저 검색하는 기능만 추가하면 되겠네요!
yoouyeon
reviewed
Aug 4, 2023
components/shop/ItemCard.tsx
Outdated
Comment on lines
28
to
39
| <div className={styles.badge}>{item.discount}%</div> | ||
| </div> | ||
| <div className={styles.details}> | ||
| <div className={styles.itemPriceTag}> | ||
| <div className={styles.title}> | ||
| <h4>{item.itemName}</h4> | ||
| </div> | ||
| <div className={styles.priceTags}> | ||
| <h5 className={styles.originalPrice}>${item.price}</h5> | ||
| <h5 className={styles.discountedPrice}>${item.salePrice}</h5> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
세일을 하지 않는 경우에는 뱃지를 빼고 가격은 원래 가격만 나오는 것도 좋을 것 같아요!!
Comment on lines
+14
to
+16
| price: 1000, | ||
| discount: 10, | ||
| salePrice: 900, |
There was a problem hiding this comment.
세일을 하지 않는 경우에는 응답이 어떻게 오게 되나요???
There was a problem hiding this comment.
discount가 0이면 salePrice랑 Price가 같아지게 될 것 같은데 한번 확인해보겠습니다!
hyobb109
commented
Aug 4, 2023
There was a problem hiding this comment.
조건문으로 세일 여부 확인하여 스타일 다르게 적용되도록 수정했습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항