Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] import order 수정 #889

Merged
merged 1 commit into from
Jun 28, 2023
Merged

[Chore] import order 수정 #889

merged 1 commit into from
Jun 28, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented Jun 26, 2023

📌 개요

  • import order github wiki에 맞춰서 수정

💻 작업사항

  • hook은 components와 [icon] 사이에 위치시켰습니다.
  • constant는 utils와 components 사이에 위치시켰습니다.

✅ 변경로직

@PHJoon PHJoon self-assigned this Jun 26, 2023
yoouyeon
yoouyeon approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와.. 수고하셨습니다!! 😆👍

@42sungwook
Copy link
Contributor

오와.. eslint로 설정할까 생각했는데 직접 다 맞추셨네요 👍👍

parksangmin1543
parksangmin1543 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 수고많으셨습니다

@PHJoon PHJoon merged commit 934de8c into main Jun 28, 2023
@PHJoon PHJoon deleted the GGFE-128-Chore-codeStyle-import-order branch June 28, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parksangmin1543 parksangmin1543 parksangmin1543 approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@PHJoon PHJoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PHJoon @42sungwook @yoouyeon @parksangmin1543