Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-117] bug match slot #870

Merged
merged 2 commits into from
Jun 23, 2023
Merged

[GGFE-117] bug match slot #870

merged 2 commits into from
Jun 23, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented Jun 23, 2023

πŸ“Œ κ°œμš”

  • match slot μ—΄λ¦° 슬둯이 μ—†μŠ΅λ‹ˆλ‹€ 둜직 μˆ˜μ •

πŸ’» μž‘μ—…μ‚¬ν•­

  • getFirstOpenSlot 둜직 μ μš©μ•ˆλ˜λ˜ λΆ€λΆ„ μˆ˜μ •
  • μ—΄λ¦° 슬둯이 μ—†μŠ΅λ‹ˆλ‹€ css μˆ˜μ •

βœ… λ³€κ²½λ‘œμ§

@PHJoon PHJoon self-assigned this Jun 23, 2023
yoouyeon
yoouyeon approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 없을 것 κ°™μŠ΅λ‹ˆλ‹€!
slot.statusκ°€ open, match, mytable 이 μ•„λ‹ˆλ©΄ λͺ¨λ‘ close인거죠 ?? μ§€κΈˆμ€ string νƒ€μž…μ΄κΈ΄ ν•œλ° λ‚˜μ€‘μ— λ¦¬ν„°λŸ΄ νƒ€μž…μœΌλ‘œ λ°”κΎΈκΈ΄ ν•΄μ•Ό ν•  것 κ°™λ„€μš”.. πŸ˜΅β€πŸ’«
μˆ˜κ³ ν•˜μ…¨μŠ΅λ‹ˆλ‹Ή

parksangmin1543
parksangmin1543 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

슬둯 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.

@PHJoon PHJoon merged commit 3890bdf into GGFE-00/Feat/api-refactoring Jun 23, 2023
@PHJoon PHJoon deleted the GGFE-117-BUG-matchSlot branch June 26, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parksangmin1543 parksangmin1543 parksangmin1543 approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@PHJoon PHJoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PHJoon @yoouyeon @parksangmin1543