Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-97] backdrop size 수정 #862

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[GGFE-97] backdrop size 수정 #862

merged 1 commit into from
Jun 22, 2023

Conversation

42sungwook
Copy link
Contributor

📌 개요

  • 화면 비율이 세로가 길 때 모달 위치 및 배경이 이상하게 뜨는 현상 수정

💻 작업사항

  • width, height를 뷰포트 대신 webkit-fill로 수정

✅ 변경로직

@42sungwook 42sungwook self-assigned this Jun 21, 2023
PHJoon
PHJoon approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@PHJoon PHJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기존에는 backdrop이 화면 세로비율이 길어지면 전체 layout이랑 width가 따로 작동했는데 수정해주셔서 맞춰서 잘 작동하네요. 고생하셨습니다!! 👍

@42sungwook 42sungwook merged commit cbe9bab into GGFE-00/Feat/api-refactoring Jun 22, 2023
@42sungwook 42sungwook deleted the GGFE-97-BUG-modal-backdrop branch June 26, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PHJoon PHJoon PHJoon approved these changes

Assignees

@42sungwook 42sungwook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@42sungwook @PHJoon