Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GGFE-100] 점수 입력 NaN 에러 #859

Merged

Conversation

yoouyeon
Copy link
Member

📌 개요

점수를 입력했다 지우면 NaN이 되는 문제를 수정했습니다

💻 작업사항

fix #768

  • input의 값이 ''가 된 경우에 intValue의 값이 NaN이 되어서 발생했던 문제라 intValueNaN인 경우에는 ''value를 설정하는 조건을 추가했습니다.
  • input 옆의 화살표를 눌렀을 때 입력할 수 있는 값의 범위를 추가했습니다.

✅ 변경로직

@yoouyeon yoouyeon self-assigned this Jun 21, 2023
Copy link
Contributor

@PHJoon PHJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 스토리북으로만 확인해봤는데 잘 작동합니다! 입력했다 지우거나, 한글 입력하거나, 1ㄹ, 1+, 1- 같은 경우도 alert창으로 다 막아주네요! 고생하셨습니다!! 👍

@42sungwook
Copy link
Contributor

저도 스토리북으로 확인했을 때는 문제없어보이네요 테섭에 올리고 다시 확인해볼게요 👍🏻

@42sungwook 42sungwook merged commit 0e10cd4 into GGFE-00/Feat/api-refactoring Jun 22, 2023
@yoouyeon yoouyeon linked an issue Jun 26, 2023 that may be closed by this pull request
@PHJoon PHJoon deleted the GGFE-100-점수-입력-NaN-에러-#768 branch June 27, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 랭크 게임 점수 입력 칸 개선사항
3 participants