Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-96] bug profile menu profile #854

Merged
merged 2 commits into from
Jun 22, 2023
Merged

[GGFE-96] bug profile menu profile #854

merged 2 commits into from
Jun 22, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented Jun 21, 2023

๐Ÿ“Œ ๊ฐœ์š”

  • ์ƒ๋Œ€๋ฐฉ ํ”„๋กœํ•„ ๋“ค์–ด๊ฐ„ ์ดํ›„ menubar ์—ด๋ฉด ๋ณธ์ธ ์‚ฌ์ง„์œผ๋กœ ๋ฐ”๋€Œ๋Š” ๋ฒ„๊ทธ ์ˆ˜์ •

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • profileState recoil์ƒํƒœ๊ฐ€ ๊ณต์œ ๋˜๋ฉด์„œ ์ƒ๊ฒผ๋˜ ๋ฌธ์ œ๋ผ menubar์—์„œ๋Š” recoil์„ ์‚ฌ์šฉํ•˜์ง€ ์•Š๊ณ  useState๋กœ profile ์ƒํƒœ๋ฅผ ๊ด€๋ฆฌํ•˜๊ฒŒ ๋ฐ”๊ฟจ์Šต๋‹ˆ๋‹ค.

โœ… ๋ณ€๊ฒฝ๋กœ์ง

@PHJoon PHJoon self-assigned this Jun 21, 2023
parksangmin1543
parksangmin1543 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋Ÿฐ ๋ฒ„๊ทธ๊ฐ€ ์žˆ๋Š”์ง€ ์ฒดํฌ๋ชปํ–ˆ์—ˆ๋Š”๋ฐ ์ˆ˜๊ณ ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค.

yoouyeon
yoouyeon approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!!! ์˜ค๋ฅ˜ ์—†์ด ์ž˜ ๋˜๋„ค์—ฌ ๐Ÿ‘

@42sungwook
Copy link
Contributor

์ง„์งœ ์ƒ๊ฐ์ง€๋„ ๋ชปํ•œ ์˜ค๋ฅ˜๋„ค์š” ใ…‹ใ…‹ ๐Ÿ‘๐Ÿป

@42sungwook 42sungwook merged commit b9bb358 into GGFE-00/Feat/api-refactoring Jun 22, 2023
@PHJoon PHJoon deleted the GGFE-96-BUG-Profile-Menu-profile branch June 23, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parksangmin1543 parksangmin1543 parksangmin1543 approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@PHJoon PHJoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PHJoon @42sungwook @yoouyeon @parksangmin1543