Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-85] Style Menubar profile 개행 추가 #847

Merged
merged 2 commits into from
Jun 20, 2023
Merged

[GGFE-85] Style Menubar profile 개행 추가 #847

merged 2 commits into from
Jun 20, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented Jun 20, 2023 •
edited
Loading

📌 개요

  • MenuBar 항목들 cursor스타일 추가
  • 73 branch에서 이미 적용됨
  • MenuBar Profile 탁구왕과 intraId 사이 개행 추가

💻 작업사항

  • 메뉴 항목들 중 cursor:point가 부분적으로 적용되어 있어서 메뉴 항목들 전체에 다 추가
  • kakao 로그인 시 게스트 id가 너무 길어서 탁구왕 intraId가 이상하게 줄바꿈돼서 나옴 -> 탁구왕(개행)intraId 형식으로 변경

✅ 변경로직

@PHJoon PHJoon self-assigned this Jun 20, 2023
@PHJoon PHJoon changed the title [GGFE-85] Style Menubar cursor style + profile 개행 추가 [GGFE-85] Style Menubar profile 개행 추가 Jun 20, 2023
parksangmin1543
parksangmin1543 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다.

yoouyeon
yoouyeon approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오 개행 추가 바로 해주셨네요 👍 수고하셨습니다!!

@42sungwook
Copy link
Contributor

이쁘게 잘나오네요👍

@42sungwook 42sungwook merged commit 9fa45c2 into GGFE-00/Feat/api-refactoring Jun 20, 2023
@PHJoon PHJoon deleted the GGFE-85-Style-MenuBar branch June 20, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parksangmin1543 parksangmin1543 parksangmin1543 approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@PHJoon PHJoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PHJoon @42sungwook @yoouyeon @parksangmin1543