Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GGFE-68] Noti reload error + currentMatch error 수정 #833

Merged
merged 7 commits into from
Jun 19, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented Jun 16, 2023

📌 개요

  • Noti reload 읽음상태 변경으로 바뀌지 않았던 부분 수정
  • Match 취소하면 opencurrentMatch 다시 false로 바뀌게 수정

💻 작업사항

  • put 요청과 get요청 동시에 들어갔던 부분 async await 추가
  • live event - match 상태에서 매칭 취소해서 null로 변하면 openCurrentMatch가 다시 false로 바뀌게 수정)

✅ 변경로직

@PHJoon PHJoon self-assigned this Jun 16, 2023
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reload 눌렀을 때 noti 읽음 상태 바로 적용되는 것 확인했습니다! 수고하셨습니다~!👍

Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 리로딩해도 잘나오네요👍

@@ -70,7 +70,7 @@ function NotiEmpty() {
return (
<div className={styles.notiEmptyWrapper}>
<div className={styles.notiEmptyText}>새로운 알림이 없습니다!</div>
<div className={styles.notiEmptyImoji}>
<div className={styles.notiEmptyEmoji}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notiEmptyEmoji라는 스타일이 따로 지정되있지 않은 것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 해당 div 태그는 필요해서 className만 제거했습니다!

Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다.

@42sungwook 42sungwook merged commit 5af5593 into GGFE-00/Feat/api-refactoring Jun 19, 2023
@PHJoon PHJoon deleted the GGFE-68-Noti-Reload-Error branch June 19, 2023 11:04
@PHJoon PHJoon restored the GGFE-68-Noti-Reload-Error branch June 19, 2023 11:05
@PHJoon PHJoon deleted the GGFE-68-Noti-Reload-Error branch June 19, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants