-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GGFE-50] Header Menu Noti 스타일 적용 #823
Merged
42sungwook
merged 28 commits into
GGFE-00/Feat/api-refactoring
from
GGFE-50-Style-Header-Modal-Menu
Jun 15, 2023
Merged
[GGFE-50] Header Menu Noti 스타일 적용 #823
42sungwook
merged 28 commits into
GGFE-00/Feat/api-refactoring
from
GGFE-50-Style-Header-Modal-Menu
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메뉴바에서 사진과 이름을 눌렀을때 이동은 하지만 메뉴바가 사라지지않습니다
사진과 이름 눌렀을 때 메뉴바 꺼지는 동작 추가했습니다! |
수정된 내용 체크했습니다 :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
Header
프로필 사라짐, 노티는 알림 개수 보여줌 (9개 넘어가면 9+로 보여줌), 공지는 사이트링크 대신 모달로 변경
Menu
42gg로고, 프로필 추가, 메뉴목록마다 항목이미지 추가
Noti
알림이 없는 경우 "알림이 없습니다 + 이모지", 알림 타입마다 알림색깔이 달라짐
기존에는 작게 알림타입 표시했었음. 경기임박, 매칭성사 등이 사라지고 색깔로 변경), 아래쪽에 물방울데코 추가됨
png 이미지 svg로 변경
❗️noti ischecked 변경을 위한 put api 추가
❗️canceledByMan 안 받는 줄 알았는데 받는 타입이라 추가
사용되는 폰트 및 이미지 추가됨
✅ 변경로직