[GGFE-48] Match Slot 스타일 #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHJoon
approved these changes
Jun 5, 2023
yoouyeon
approved these changes
Jun 5, 2023
components/match/MatchBoard.tsx
Outdated
Comment on lines
92
to
118
| {matchBoards.map((slot, index, array) => { | ||
| if (stringToHourMin(slot.startTime).sMin !== '00') { | ||
| return null; | ||
| } | ||
| const count = countSlotsInHour(slot); | ||
| const nextSlots = array.slice(index, index + count); | ||
|
|
||
| return ( | ||
| <div | ||
| key={index} | ||
| ref={getScrollCurrentRef(stringToHourMin(slot.startTime).nHour)} | ||
| > | ||
| {stringToHourMin(slot.startTime).sMin === '00' && ( | ||
| <MatchTime key={index} startTime={slot.startTime} /> | ||
| )} | ||
| <div className={styles.slotGrid}> | ||
| {nextSlots.map((nextSlot, nextIndex) => ( | ||
| <MatchSlot | ||
| key={index + nextIndex} | ||
| toggleMode={toggleMode} | ||
| slot={nextSlot} | ||
| /> | ||
| ))} | ||
| </div> | ||
| </div> | ||
| ); | ||
| })} |
There was a problem hiding this comment.
return문의 로직이 좀 길어져서 보기 어려운 것 같기도 한데, matchBoards 배열을 return문 위에서 이중배열로 변환한 뒤에 return문에서는 기존처럼 이중배열로 다루는 것은 어떨까요?? (가능한 방법인지 잘 모르겠네요;;)
There was a problem hiding this comment.
프론트에서 애초에 이중배열로 바꾸는 처리는 비효율적이라고 생각해서 이렇게 바꿔본거였는데 관리자 페이지쪽하다가 결국 이중배열로 써야될 것 같아서 백에 다시 이중배열로 넘겨달라고 요청했어요.
|
아직 라디오 모드랑 스타일 적용이 완성되지 않았는데 그 부분은 다시 PR남기도록 하겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
✅ 변경로직