Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-58] match slot 토글버튼 -> 라디오버튼 변경 #811

Merged
merged 3 commits into from
Jun 5, 2023
Merged

[GGFE-58] match slot 토글버튼 -> 라디오버튼 변경 #811

merged 3 commits into from
Jun 5, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented Jun 4, 2023 •
edited
Loading

📌 개요

  • match slot 토글버튼에서 라디오버튼으로 변경

💻 작업사항

  • 라디오 버튼으로 변경
  • 매뉴얼 안에서는 토글 그대로 남아있음
  • Both인 경우 css 스타일 적용할 때 버튼스타일 Both 키 추가필요

✅ 변경로직

parksangmin1543
parksangmin1543 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다!

parksangmin1543
parksangmin1543 approved these changes Jun 5, 2023 •
edited
Loading
View reviewed changes
yoouyeon
yoouyeon approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 확인했습니다! 매뉴얼 토글이랑 내용도 나중에 변경해줘야 할 듯 하네요....
수고하셨습니다!!! 👍

42sungwook
42sungwook approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다👍🏻👍🏻

@42sungwook 42sungwook merged commit b1f8540 into GGFE-00/Feat/api-refactoring Jun 5, 2023
@PHJoon PHJoon deleted the GGFE-58-Match-slot-라디오-버튼 branch June 16, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42sungwook 42sungwook 42sungwook approved these changes

@parksangmin1543 parksangmin1543 parksangmin1543 approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@PHJoon PHJoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PHJoon @yoouyeon @parksangmin1543 @42sungwook