Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GGFE-56] noti error 수정 및 newNoti 이름 변경 #802

Merged
merged 4 commits into from
Jun 2, 2023

Conversation

PHJoon
Copy link
Contributor

@PHJoon PHJoon commented May 31, 2023

📌 개요

  • noti 리스트 null인 경우 에러 수정
  • newNoti 이름 전부 변경

💻 작업사항

  • noti 리스트가 null인 경우 enemyId, message 파싱하는 부분에서 null을 split하려해서 에러나던 부분 수정
  • newNoti 이름들 전부 Noti로 이름 변경
  • message가 null 인 경우도 '알림을 불러올 수 없습니다' 추가

✅ 변경로직

@PHJoon PHJoon self-assigned this May 31, 2023
Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 잘되네요👍👍

@PHJoon
Copy link
Contributor Author

PHJoon commented Jun 1, 2023

message가 null 인 경우도 '알림을 불러올 수 없습니다'로 뜨는 것도 추가했습니다.

Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!
null인 메시지들도 알림을 불러올 수 없다고 잘 뜨네요!! 👍

@42sungwook 42sungwook merged commit ab3e790 into GGFE-00/Feat/api-refactoring Jun 2, 2023
@PHJoon PHJoon deleted the GGFE-56-Noti-Error branch June 16, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants