[GGFE-36] seasonlist #798

parksangmin1543 · 2023-05-26T10:03:26Z

📌 개요

seasonlist api 변경

💻 작업사항

시즌별 이름 리스트 조회
수정전
/pingpong/seasonlist

seasonmode: 'both'
[{
id: number
name: string
},{…}]

수정후

/pingpong/seasons
{
  "seasonList": [
    {
      "id": 0,
      "name": "string"
    }
  ]
}

수정 전에는 seasonList[0]에 최신 시즌이 있었으나 수정후 마지막에 오는 것으로 바뀌었습니다.
seasonMode를 주던 방식에서 삭제하고 기본으로 rank를 사용

✅ 변경로직

PHJoon · 2023-05-30T06:55:52Z

변경사항 확인했습니다!

42sungwook

확인했습니다!

42sungwook · 2023-05-30T07:43:28Z

components/Layout/MenuBar.tsx

  // const resetOpenMenuBar = useResetRecoilState(openMenuBarState);
  const HeaderState = useContext<HeaderContextState | null>(HeaderContext);

  const setModal = useSetRecoilState(modalState);
  const menuList = [
    {
-      name: `${seasonMode === 'normal' ? 'VIP' : '랭킹'}`,
+      name: `'랭킹'`,


이거는 name: '랭킹', 으로만 적어도 될거같아요

네 수정했습니다

yoouyeon

변경사항 확인했습니다!!! 수고하셨습니다 👍👍

yoouyeon · 2023-05-30T09:05:28Z

components/Layout/NewMenuBar/MenuBarElement.tsx

-      name: `${
-        MenuContext?.seasonMode.seasonMode === 'normal' ? 'VIP' : '랭킹'
-      }`,
+      name: `${MenuContext?.seasonMode === 'normal' ? 'VIP' : '랭킹'}`,


seasonMode가 언제 normal이 되는지 궁금합니다!

현재 바뀌는 부분은 아니지만 메인랭킹리스트와 메뉴바같이 normal일때 css가 변하는 부분이 있는 경우는 크게 수정하지 않았습니다.

나중에도 normal인 경우가 없을 것 같아서 나중에 CSS랑 같이 불필요하게 normal 사용되는 부분 수정하긴 해야 할 것 같네요!! 알겠습니다 👍

yoouyeon · 2023-05-30T09:05:52Z

components/Layout/NewMenuBar/MenuBarProvider.tsx

 import { Modal } from 'types/modalTypes';

 export interface NewMenuContextState {
-  seasonMode: SeasonList;
+  seasonMode: string;


seasonMode의 타입을 string으로 하는 것 보다는 SeasonMode 타입으로 지정하는게 좀 더 의미적으로 좋을 것 같아요!!

감사합니다! 수정하겠습니다.

Sangmin Park added 2 commits May 24, 2023 15:51

[Feat] [GGFE-36] seasonlist 업데이트

7ede9d6

[Feat] [GGFE-36] seasonlist 테스트

df65029

42sungwook approved these changes May 30, 2023

View reviewed changes

Sangmin Park added 2 commits May 30, 2023 17:12

[Feat] [GGFE-36] seasonmode 부분 삭제

ae7f605

[Feat] [GGFE-36] seasonmode 부분 삭제

9ffc273

yoouyeon reviewed May 30, 2023

View reviewed changes

[Feat] [GGFE-36] seasonMode 타입변경

f6fa149

42sungwook merged commit 703a722 into GGFE-00/Feat/api-refactoring May 30, 2023

yoouyeon assigned parksangmin1543 May 31, 2023

parksangmin1543 deleted the GGFE-36-seasonlist branch June 12, 2023 08:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GGFE-36] seasonlist #798

[GGFE-36] seasonlist #798

parksangmin1543 commented May 26, 2023 •

edited

Loading

PHJoon commented May 30, 2023

42sungwook left a comment

42sungwook May 30, 2023

parksangmin1543 May 30, 2023

yoouyeon left a comment

yoouyeon May 30, 2023

parksangmin1543 May 30, 2023 •

edited

Loading

yoouyeon May 30, 2023

yoouyeon May 30, 2023

parksangmin1543 May 30, 2023

[GGFE-36] seasonlist #798

[GGFE-36] seasonlist #798

Conversation

parksangmin1543 commented May 26, 2023 • edited Loading

📌 개요

💻 작업사항

✅ 변경로직

PHJoon commented May 30, 2023

42sungwook left a comment

Choose a reason for hiding this comment

42sungwook May 30, 2023

Choose a reason for hiding this comment

parksangmin1543 May 30, 2023

Choose a reason for hiding this comment

yoouyeon left a comment

Choose a reason for hiding this comment

yoouyeon May 30, 2023

Choose a reason for hiding this comment

parksangmin1543 May 30, 2023 • edited Loading

Choose a reason for hiding this comment

yoouyeon May 30, 2023

Choose a reason for hiding this comment

yoouyeon May 30, 2023

Choose a reason for hiding this comment

parksangmin1543 May 30, 2023

Choose a reason for hiding this comment

parksangmin1543 commented May 26, 2023 •

edited

Loading

parksangmin1543 May 30, 2023 •

edited

Loading