-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GGFE-14] Game - 게임 목록 조회 #795
Merged
The head ref may contain hidden characters: "GGFE-14-\uAC8C\uC784-\uBAA9\uB85D-\uC870\uD68C"
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
임시로 변경한 것으로 변경 가능성 있음.
변경사항 확인했습니다! |
parksangmin1543
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경사항 확인했습니다.
42sungwook
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
진행된 (진행중인) 게임 목록을 받아오는 api 변경
💻 작업사항
🛠 전체 게임 목록 조회 🛠
🛠 랭크 게임 목록 조회 🛠
🛠 일반 게임 목록 조회 🛠
makePath
함수 수정lastGameId
→ page로 변함에 따라 다음 페이지로 받아올 수 있게InfScroll
수정SeasonMode
타입을 기존 소문자에서 대문자로 수정types/gameTypes.ts
의 타입 수정❗️ 시즌 api가 아직 연결이 안되어서 랭크 게임 목록 조회는 테스트가 안된 상태입니다. ❗️
✅ 변경로직