-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GGFE-16] Game - 게임 결과 등록과 조회 #790
Merged
42sungwook
merged 6 commits into
GGFE-00/Feat/api-refactoring
from
GGFE-16-게임-결과-등록과-조회
May 30, 2023
The head ref may contain hidden characters: "GGFE-16-\uAC8C\uC784-\uACB0\uACFC-\uB4F1\uB85D\uACFC-\uC870\uD68C"
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4373967
[Chores] [Feat] [GGFE-16] Team, Player 타입 속성 추가
yoouyeon 477d1ac
Merge branch 'GGFE-00/Feat/api-refactoring' of https://github.com/42o…
yoouyeon 80c9fc2
[Feat] [GGFE-16] 랭크 게임 결과 등록 api 수정
yoouyeon bf89347
[Feat] [GGFE-16] 일반 게임 결과 등록 api 수정
yoouyeon 1fa779a
[Feat] [GGFE-16] 랭크 / 일반 게임 결과 조회 응답 타입 지정
yoouyeon 7b84a38
[Fix] [GGFE-16] mode 누락 추가, 가독성을 위한 destructuring
yoouyeon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currentGame을 반복해서 써야되면
const { gameId, matchTeamsInfo } = currentGame;
처럼 destructuring해서 쓰는 방법도 있어요
참고 사이트 : http://hacks.mozilla.or.kr/2015/09/es6-in-depth-destructuring/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 쓰면서도 뭔가 이상하다 생각했는데 이렇게 쓰는 방법이 있었네요......
destructing 하는 쪽이 더 읽기 좋아보이니 이렇게 수정하겠습니다 👍