Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GGFE-28] Admin - Noti #788

Merged
merged 4 commits into from
May 30, 2023
Merged

[GGFE-28] Admin - Noti #788

merged 4 commits into from
May 30, 2023

Conversation

42sungwook
Copy link
Contributor

@42sungwook 42sungwook commented May 24, 2023 •
edited
Loading

πŸ“Œ κ°œμš”

  • κ΄€λ¦¬μž Noti api μˆ˜μ •

πŸ’» μž‘μ—…μ‚¬ν•­

  • πŸ›  전체 μ•Œλ¦Ό 생성 πŸ›  : μ‚­μ œ

  • πŸ›  νŠΉμ • μœ μ € μ•Œλ¦Ό 전솑(생성) πŸ› 
    μˆ˜μ • μ „: pingpong/admin/notifications/{intraId}
    μˆ˜μ • ν›„: pingpong/admin/notifications

  • πŸ›  μ „μ†‘ν•œ μ•Œλ¦Ό 전체 쑰회 πŸ›  : 변경사항 μ—†μŒ

  • πŸ›  νŠΉμ • μœ μ € μ•Œλ¦Ό 쑰회 πŸ› 
    μˆ˜μ • μ „: pingpong/admin/notifications?q=${keyword}&page=${page}&size?=${recordSize}
    μˆ˜μ • ν›„: pingpong/admin/notifications?intraId=${intraId}&page=${page}&size?=${recordSize}

++ 전체 μœ μ € μ•Œλ¦Ό κΈ°λŠ₯ μ‚­μ œ -> λ²„νŠΌ, κΈ°λŠ₯ μ‚­μ œ 및 검색바, λ²„νŠΌ μœ„μΉ˜ μ‘°μ •

βœ… λ³€κ²½λ‘œμ§

  • table 정보가 λ°±μ—μ„œ 쑰금 λ‹€λ₯΄κ²Œ λ„˜μ–΄μ˜€λŠ” ν˜„μƒ -> λ°± λ‹΄λ‹Ήμžλž‘ 확인 ν•„μš”

@42sungwook 42sungwook self-assigned this May 24, 2023
yoouyeon
yoouyeon approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@yoouyeon yoouyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ πŸ‘πŸ‘

@PHJoon
Copy link
Contributor

PHJoon commented May 26, 2023

변경사항 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€!

parksangmin1543
parksangmin1543 approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@parksangmin1543 parksangmin1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경사항 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.

@42sungwook 42sungwook merged commit b56e2ed into GGFE-00/Feat/api-refactoring May 30, 2023
@42sungwook 42sungwook deleted the GGFE-28-Admin-Noti branch May 31, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parksangmin1543 parksangmin1543 parksangmin1543 approved these changes

@yoouyeon yoouyeon yoouyeon approved these changes

Assignees

@42sungwook 42sungwook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@42sungwook @PHJoon @yoouyeon @parksangmin1543