Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/패널티 모달 api 붙이기 #710 #729

Merged
merged 6 commits into from
Mar 8, 2023

Conversation

Wilbur0306
Copy link
Contributor

📌 개요

  • 패널티 모달 api 붙이기 및 개선

💻 작업사항

  • API 붙이기
  • 해방 시간: 한 자리수 → 두 자리수 표기 변경
  • 성공 토스트 메시지의 위치 → api 요청 뒤로 이동

관련 이슈

@Wilbur0306 Wilbur0306 added the admin 관리자 페이지에서 발생한 issue label Mar 8, 2023
@Wilbur0306 Wilbur0306 requested a review from a team as a code owner March 8, 2023 10:29
@Wilbur0306 Wilbur0306 self-assigned this Mar 8, 2023
@Wilbur0306 Wilbur0306 requested review from mike2ox, raehy19 and 42sungwook and removed request for a team March 8, 2023 10:29
Copy link
Contributor

@mike2ox mike2ox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저랑 같이 작업했던 부분들이 있어서 문제 되는 부분은 없어 보이네요. 윤년일 때 2월29일을 new Date에서 못잡아주는 것 같던데 이 부분은 이슈 남겨주시면 감사하겠습니다!

@Wilbur0306 Wilbur0306 merged commit 62c911b into main Mar 8, 2023
@Wilbur0306 Wilbur0306 deleted the Feat/패널티-모달-API-붙이기-#710 branch March 8, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin 관리자 페이지에서 발생한 issue
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants