Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] 유저 검색 intraID 고정 안되는 에러 수정 #701 #702

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[Fix] 유저 검색 intraID 고정 안되는 에러 수정 #701 #702

merged 1 commit into from
Mar 2, 2023

Conversation

Wilbur0306
Copy link
Contributor

📌 개요

  • 유저 검색 기능 intraID 고정 안되는 에러 수정

💻 작업사항

  • 관리자 페이지의 알림 관리 카데고리에서 유저 검색할 때 검색된 intraID 클릭 시, 입력창에 intraID가 고정되지 않는 에러 수정

확인 방법

  1. npm i && npm run dev 실행
  2. 관리자 페이지의 알림 관리 카데고리로 이동
  3. "유저 검색하기" 입력창에 intraID 아무거나 검색
  4. 추천 검색어로 뜨는 intraID 중 원하는 intraID 클릭
  5. 클릭 시에 유저 검색하는 입력창에 클릭한 intraID가 자동으로 고정이 되는지 확인

관련 이슈

@Wilbur0306 Wilbur0306 added bug Something isn't working admin 관리자 페이지에서 발생한 issue labels Mar 1, 2023
@Wilbur0306 Wilbur0306 requested a review from a team as a code owner March 1, 2023 08:46
@Wilbur0306 Wilbur0306 self-assigned this Mar 1, 2023
@Wilbur0306 Wilbur0306 requested review from mike2ox, raehy19 and 42sungwook and removed request for a team March 1, 2023 08:46
42sungwook
42sungwook approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다. 사소한 부분인데 잘 캐치해주셨네요 👍👍

raehy19
raehy19 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@raehy19 raehy19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인해보니 잘 작동하네요 수고하셨습니다 ! 버그 이슈에 대한 작업은 브랜치를 Fix/~ 로 만들면 더 좋을거같아요 :)

@Wilbur0306 Wilbur0306 merged commit 7043645 into main Mar 2, 2023
@Wilbur0306 Wilbur0306 deleted the Feat/-관리자-유저-검색-intraID-고정-기능-추가-#701 branch March 2, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42sungwook 42sungwook 42sungwook approved these changes

@raehy19 raehy19 raehy19 approved these changes

@mike2ox mike2ox Awaiting requested review from mike2ox mike2ox was automatically assigned from 42organization/fe_2nd

Assignees

@Wilbur0306 Wilbur0306

Labels
admin 관리자 페이지에서 발생한 issue bug Something isn't working
Projects
No open projects
🍌 Version 2 - Frontend
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wilbur0306 @raehy19 @42sungwook