Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wilbur0306
requested review from
mike2ox,
raehy19 and
42sungwook
and removed request for
a team
mike2ox
reviewed
Feb 22, 2023
raehy19
approved these changes
Feb 24, 2023
42sungwook
approved these changes
Feb 24, 2023
Comment on lines
+12
to
+13
| return <MuiAlert elevation={6} ref={ref} variant='filled' {...props} />; | ||
| }); |
There was a problem hiding this comment.
조사해보니 흥미로운 내용이 있어서 공유할게요
forwardRef
- 다른 컴포넌트의 내부 html 요소에 접근할 때(ref 사용) 사용하는 react built-in API (ref : 일반적인 상황에서 쓰이는 prop은 아님)
MuiAlert
- MUI에서 제공해주는 Alert 컴포넌트
- elevation : 컴포넌트 뒤에 나오는 shadow 정도
- variant : 어떤 디자인의 Alert인지 정해주는 prop
- 불필요한 useState, 함수들 제거 - useRef를 사용해 불필요한 render현상 막음 - 다음 미션 주석 작성
|
@raehy19 리뷰 감사합니다 :)
요거 같은 경우 toast와 modal는 별개로 동작해야하는 컴포넌트들이라 동작이 느리게 보이는 겁니다. |
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
-전체 유저 알림 모달과 toast message 연결
💻 작업사항