Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/일반 유저가 관리자 페이지 접근 가능한 문제 #665 #667

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Fix/일반 유저가 관리자 페이지 접근 가능한 문제 #665 #667

merged 4 commits into from
Feb 23, 2023

Conversation

raehy19
Copy link
Contributor

@raehy19 raehy19 commented Feb 20, 2023

📌 개요

  • 관리자 페이지 권한 없이 접근했을 때 접근이 가능했던 문제 수정했습니다

💻 작업사항

  • 관리자 권한이 없을 경우 권한 없다는 메시지를 띄우고 홈으로 돌아가도록 하는 페이지가 보이도록 변경

image

기타

@raehy19 raehy19 requested a review from a team as a code owner February 20, 2023 06:04
@raehy19 raehy19 self-assigned this Feb 20, 2023
@raehy19 raehy19 requested review from mike2ox, salty0306 and 42sungwook and removed request for a team February 20, 2023 06:04
42sungwook
42sungwook approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 나오는지 확인했습니다! 몇가지 궁금증만 올려봐요

components/admin/AdminReject.tsx Show resolved Hide resolved
styles/admin/AdminReject.module.scss Outdated Show resolved Hide resolved
salty0306
salty0306 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@salty0306 salty0306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 잘 작동되는 것 확인했습니다!

mike2ox
mike2ox approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@mike2ox mike2ox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요! UX적으로 조금 개선하면 좋을거 같아서 몇자 써봤습니다!
권한 막는거는 잘 동작해서 approve!

components/Layout/Layout.tsx Show resolved Hide resolved
@raehy19 raehy19 added the bug Something isn't working label Feb 22, 2023
@raehy19 raehy19 merged commit 844bb77 into main Feb 23, 2023
@raehy19 raehy19 deleted the Fix/일반_유저가_관리자_페이지_접근_가능한_문제_#665 branch February 23, 2023 07:48
raehy19 added a commit that referenced this pull request Feb 24, 2023
@raehy19
[Feat] : 관리자 페이지 이전 공지사항들을 조회할 수 있도록 기능 추가하고 백엔드 api와 연동 #667
aa5e282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42sungwook 42sungwook 42sungwook approved these changes

@salty0306 salty0306 salty0306 approved these changes

@mike2ox mike2ox mike2ox approved these changes

Assignees

@raehy19 raehy19

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raehy19 @mike2ox @salty0306 @42sungwook