Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/make feedback page #659

Merged
merged 24 commits into from
Feb 20, 2023
Merged

Feat/make feedback page #659

merged 24 commits into from
Feb 20, 2023

Conversation

mike2ox
Copy link
Contributor

@mike2ox mike2ox commented Feb 15, 2023

๐Ÿ“Œ ๊ฐœ์š”

  • ํ”ผ๋“œ๋ฐฑ ํŽ˜์ด์ง€ ๊ตฌํ˜„

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • ํŽ˜์ด์ง€๋„ค์ด์…˜ ์ ์šฉ
  • API ์ ์šฉ
  • ํ”ผ๋“œ๋ฐฑ ๋ณ€๊ฒฝ ์•Œ๋ฆผ ๋ชจ๋‹ฌ
  • ํ…Œ์ด๋ธ” ์Šคํƒ€์ผ ์ ์šฉ

์‹œ์—ฐ

  1. ํŒจํ‚ค์ง€ ์ตœ์‹ ํ™” ๋ฐ env ๋งž์ถ”๊ธฐ
npm i & npm run dev
  1. ๋ธŒ๋ผ์šฐ์ € ์—ด๊ธฐ & ํ”ผ๋“œ๋ฐฑ ๊ด€๋ฆฌ ์„ ํƒ
  2. ํ™•์ธ

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2023-02-15 แ„‹แ…ฉแ„’แ…ฎ 3 49 51

๊ด€๋ จ ์ด์Šˆ

@mike2ox mike2ox added enhancement New feature or request admin ๊ด€๋ฆฌ์ž ํŽ˜์ด์ง€์—์„œ ๋ฐœ์ƒํ•œ issue labels Feb 15, 2023
@mike2ox mike2ox self-assigned this Feb 15, 2023
@mike2ox mike2ox requested a review from a team as a code owner February 15, 2023 06:52
@mike2ox mike2ox requested review from raehy19, Wilbur0306 and 42sungwook and removed request for a team February 15, 2023 06:52
@mike2ox mike2ox marked this pull request as draft February 15, 2023 06:52
Copy link
Contributor

@Wilbur0306 Wilbur0306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API ๋ฐ›์•„์™€์„œ ์ ์šฉ ์ž˜ ๋œ ๊ฒƒ๊นŒ์ง€ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!
ํŽ˜์ด์ง€๋„ค์ด์…˜ ๋˜ํ•œ ๊น”๋”ํ•˜๊ฒŒ ๊ตฌํ˜„ํ•˜์…จ์Šต๋‹ˆ๋‹ค.
์ˆ˜๊ณ  ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค๐Ÿ˜Š

@Wilbur0306 Wilbur0306 self-requested a review February 15, 2023 09:41
Copy link
Contributor

@Wilbur0306 Wilbur0306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API ๋ฐ›์•„์™€์„œ ์ ์šฉ ์ž˜ ๋œ ๊ฒƒ๊นŒ์ง€ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!
ํŽ˜์ด์ง€๋„ค์ด์…˜ ๋˜ํ•œ ๊น”๋”ํ•˜๊ฒŒ ๊ตฌํ˜„ํ•˜์…จ์Šต๋‹ˆ๋‹ค.
์ˆ˜๊ณ  ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค๐Ÿ˜Š

@mike2ox mike2ox marked this pull request as ready for review February 16, 2023 13:05
@mike2ox
Copy link
Contributor Author

mike2ox commented Feb 16, 2023

์ถ”๊ฐ€ ์™„๋ฃŒ๋œ ์ž‘์—…์ƒํ™ฉ

  • ๋„ˆ๋ฌด ๊ธด content๋กœ ์ธํ•ด ๋”๋ณด๊ธฐ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ํ”ผ๋“œ๋ฐฑ ์•Œ๋ฆผ ์ „์†ก ๋ชจ๋‹ฌ ์Šคํƒ€์ผ ๊ฐœ์„ 
  • ํ”ผ๋“œ๋ฐฑ ์ƒํƒœ ๋ณ€๊ฒฝ์— ๋”ฐ๋ฅธ ํ…Œ์ด๋ธ” ๊ฐ’ ๋ฆฌ๋ Œ๋”๋ง

๋‚จ์€ ๋ฏธ์…˜

  • ์ „์ฒด์ ์ธ ์Šคํƒ€์ผ ๊ฐœ์„ (dropdown)

Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ •๋ง ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค. ์Šคํƒ€์ผ์ชฝ๋งŒ ์ˆ˜์ •ํ•˜์‹œ๋ฉด ์™„๋ฒฝํ•  ๊ฒƒ ๊ฐ™๋„ค์š”!
์ €๋„ ๋ถ„๋ฐœํ•ด์„œ ์ž‘์—…์„ ๋” ๋งŽ์ด ํ•ด๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค!๐Ÿฅฒ
ํŠน๋ณ„ํžˆ ๋ฌธ์ œ๋Š” ์•ˆ๋ณด์—ฌ์„œ ๋ช‡๊ฐ€์ง€ ๊ถ๊ธˆ์ ๋“ค๋งŒ ์ ์–ด๋†จ์Šต๋‹ˆ๋‹ค. ์‹œ๊ฐ„๋˜์‹ค ๋•Œ ๋‹ต ๋‹ฌ์•„์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค~

components/admin/feedback/FeedbackTable.tsx Show resolved Hide resolved
components/admin/feedback/FeedbackTable.tsx Outdated Show resolved Hide resolved
components/modal/admin/AdminDetailContentModal.tsx Outdated Show resolved Hide resolved
pages/api/pingpong/admin/feedback/index.ts Show resolved Hide resolved
Comment on lines +4 to +11
export type TableFormat = {
[key in TableName]: {
name: string;
columns: string[];
etc?: {
type: EtcType;
value: string[];
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

etc๋ผ๊ณ  ์ด๋ฆ„ ์ง€์œผ์‹  ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ด์š” ์ธ์ž๊ฐ€ ์ถ”๊ฐ€๋  ๊ฐ€๋Šฅ์„ฑ์€ ์—†์„๊นŒ์š”? ์žˆ๋‹ค๋ฉด ๊ทธ ์ธ์ž์˜ ์ด๋ฆ„์ด ์• ๋งคํ•ด์งˆ ๊ฒƒ ๊ฐ™์€๋ฐ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ธ์ž๊ฐ€ ์ถ”๊ฐ€๋  ๊ฐ€๋Šฅ์„ฑ๊นŒ์ง€ ๊ณ ๋ คํ•˜์ง„ ์•Š์•˜์ง€๋งŒ ์ด ๋ถ€๋ถ„์€ ํ…Œ์ด๋ธ” ๊ณต์šฉ ์ปดํฌ๋„ŒํŠธ์—์„œ ํŠน์ • ํŽ˜์ด์ง€์—์„œ ์“ฐ์ผ ๋‚ด์šฉ์„ ํŠน์ •์ง“๊ธฐ ์œ„ํ•ด ๋งŒ๋“  type์ด๋ผ ๊ธฐ๋Šฅ์ƒ์œผ๋กœ ๋ฌธ์ œ๊ฐ€ ์—†์–ด์ง€๋ฉด ๊ณต์šฉ ์ปดํฌ๋„ŒํŠธ ์ œ์ž‘์‹œ ๋ฆฌํŒฉํ† ๋ง์„ ์ง„ํ–‰ํ•  ์ƒ๊ฐ์ด๊ธด ํ–ˆ์Šต๋‹ˆ๋‹ค.
TableFormat ๊ตฌ์กฐ๋Š” ์•„์ง ์ƒ๊ฐ์ค‘์ธ๋ฐ ์กฐ์–ธํ•ด์ฃผ์‹  ๋ถ€๋ถ„ ์žŠ์ง€์•Š๊ณ  ์ ์šฉํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค ๐Ÿ˜ƒ

@mike2ox mike2ox requested a review from Wilbur0306 February 17, 2023 15:14
Copy link
Contributor

@Wilbur0306 Wilbur0306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ •๋ง ์ˆ˜๊ณ  ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค๐Ÿ˜Š
toast message ๋ถ™์ด๋Š” ํ…Œ์ŠคํŠธ ํ•  ๋•Œ์— ๋น„ํ•ด ์ˆ˜์ • ์‚ฌํ•ญ์ด ๋ช‡ ๊ฐœ ์ถ”๊ฐ€๋˜์–ด ์žฌํ™•์ธํ•˜์˜€์Šต๋‹ˆ๋‹ค.
merge ํ•˜์‹œ๋ฉด ๋ฐ”๋กœ toast message ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin ๊ด€๋ฆฌ์ž ํŽ˜์ด์ง€์—์„œ ๋ฐœ์ƒํ•œ issue enhancement New feature or request
Projects
No open projects
Status: โœ… Done
Development

Successfully merging this pull request may close these issues.

3 participants