Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/관리자 유저 모달 개선 #647 #649

Merged
merged 31 commits into from
Feb 18, 2023
Merged

Feat/관리자 유저 모달 개선 #647 #649

merged 31 commits into from
Feb 18, 2023

Conversation

42sungwook
Copy link
Contributor

@42sungwook 42sungwook commented Feb 11, 2023 •
edited
Loading

📌 개요

  • 코멘트 주신 내용 적용

💻 작업사항

  • console.log 제거 및 수정
  • import 및 css 정렬 수정

ETC

지금 api 정보가 email로 보내서 이메일이 수정이 안되는데 오늘내로 고쳐질 것 같습니다 (명세는 eMail)
유저 role 타입도 한글 string으로 보내고 있어 바꿔주신다고 했습니다
이 두가지 내용 제외하고는 get요청, put요청 보내보시면 잘 바뀌는지 확인가능해요!

@42sungwook 42sungwook added enhancement New feature or request admin 관리자 페이지에서 발생한 issue labels Feb 11, 2023
@42sungwook 42sungwook requested a review from a team February 11, 2023 07:07
@42sungwook 42sungwook self-assigned this Feb 11, 2023
@42sungwook 42sungwook requested review from mike2ox, raehy19, Wilbur0306 and imJusttheresd and removed request for a team February 11, 2023 07:07
mike2ox
mike2ox reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@mike2ox mike2ox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주말간에 모달 스타일에 신경쓰신게 많이 보이네요 고생하셨습니다!
몇가지 코멘트 남겨드린거 답변 달아주시면 되겠고 사진 업로드 관련해서 아래 이슈 확인 부탁드립니다.

  • 업로드할 사진 미리보기는 되지만 정작 전송(변경)버튼을 클릭하면 userInfo안에는 업로드 전 사진 url이 담겨있습니다.

components/modal/admin/AdminProfileModal.tsx Outdated Show resolved Hide resolved
components/modal/admin/AdminProfileModal.tsx Outdated Show resolved Hide resolved
components/modal/admin/AdminProfileModal.tsx Show resolved Hide resolved
types/admin/adminUserTypes.ts Outdated Show resolved Hide resolved
styles/admin/modal/AdminProfile.module.scss Show resolved Hide resolved
Wilbur0306
Wilbur0306 reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@Wilbur0306 Wilbur0306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모달을 만드는 완전 처음부터 지금까지의 과정을 옆에서 지켜본 사람으로서 기능적인 부분도 당연하지만, 디자인적으로 변한게 많은 것이 확 느껴졌습니다. NaN으로 표시되어서 고쳐야했던 부분도 말끔하게 수정해주신 것을 확인할 수 있었습니다! 수정하시느라 수고 많으셨습니다!

raehy19
raehy19 suggested changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@raehy19 raehy19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !! 모송님이 많이 써주셔서 크게 더 고칠게 없는거같기도 한데 사소한 코멘트 확인 부탁드립니다 ~

components/modal/admin/AdminProfileModal.tsx Show resolved Hide resolved
components/modal/admin/AdminProfileModal.tsx Show resolved Hide resolved
@42sungwook 42sungwook closed this Feb 14, 2023
@42sungwook 42sungwook reopened this Feb 15, 2023
@42sungwook 42sungwook requested a review from a team as a code owner February 15, 2023 02:56
raehy19
raehy19 suggested changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@raehy19 raehy19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 큰 문제는 없는데 리팩토링할만한 요소가 있는것같아서 소소한 코멘트 확인해주시면 될거같아요 ~

components/modal/admin/AdminProfileModal.tsx Show resolved Hide resolved
hooks/useUploadImg.ts Outdated Show resolved Hide resolved
components/modal/admin/AdminProfileModal.tsx Outdated Show resolved Hide resolved
styles/admin/modal/AdminProfile.module.scss Outdated Show resolved Hide resolved
mike2ox
mike2ox suggested changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@mike2ox mike2ox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필요없는 주석은 삭제해주시고 래현님 말씀처럼 역할이 끝난(main에 붙이는 PR에서) console.log는 삭제해주시는게 좋습니다.
admin/users.tsx에서 intraId가 하드코딩되어 있던데 유저관리 페이지에 table 만들어서 올려드리도록 할게요

components/modal/admin/AdminProfileModal.tsx Show resolved Hide resolved
hooks/useUploadImg.ts Outdated Show resolved Hide resolved
pages/api/admin/users/index.ts Outdated Show resolved Hide resolved
@42sungwook 42sungwook closed this Feb 17, 2023
@42sungwook 42sungwook reopened this Feb 17, 2023
@42sungwook 42sungwook linked an issue Feb 17, 2023 that may be closed by this pull request
[Feat] 유저 프로필 모달 개선 #647
Closed
11 tasks
mike2ox
mike2ox approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@mike2ox mike2ox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

components/modal/admin/AdminProfileModal.tsx Outdated Show resolved Hide resolved
@42sungwook 42sungwook requested a review from mike2ox February 17, 2023 08:32
@mike2ox mike2ox mentioned this pull request Feb 17, 2023
Merged
9 tasks
raehy19
raehy19 approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@raehy19 raehy19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~ 수고하셨습니다 !

@42sungwook 42sungwook merged commit 546c28c into main Feb 18, 2023
@42sungwook 42sungwook deleted the Feat/관리자-유저-모달-개선-#647 branch February 18, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raehy19 raehy19 raehy19 approved these changes

@imJusttheresd imJusttheresd Awaiting requested review from imJusttheresd imJusttheresd was automatically assigned from 42organization/fe_2nd

@Wilbur0306 Wilbur0306 Awaiting requested review from Wilbur0306

@mike2ox mike2ox Awaiting requested review from mike2ox

Assignees

@42sungwook 42sungwook

Labels
admin 관리자 페이지에서 발생한 issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 유저 프로필 모달 개선
4 participants
@42sungwook @mike2ox @raehy19 @Wilbur0306