Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 프론트 관리자 페이지 레이아웃 생성 #621 #624

Merged
merged 8 commits into from
Jan 31, 2023
Merged

[Feat] 프론트 관리자 페이지 레이아웃 생성 #621 #624

merged 8 commits into from
Jan 31, 2023

Conversation

raehy19
Copy link
Contributor

@raehy19 raehy19 commented Jan 30, 2023

📌 개요

  • 프론트에서 접근 가능한 관리자 페이지 생성

💻 작업사항

  • 관리자만 접속 가능한 '/admin/관리자메뉴' 관리자 페이지 생성 및 레이아웃, 좌측 네비게이션바, 라우팅 처리

관련 이슈

@raehy19 raehy19 self-assigned this Jan 30, 2023
mike2ox
mike2ox reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@mike2ox mike2ox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
리팩토링은 추후 배포직전에 하던가 MVP2-2때 하면 되지만 UX적인거는 지금 잡아가면 좋다고 생각합니다!

components/Layout/Layout.tsx Show resolved Hide resolved
styles/admin/Layout.module.scss Show resolved Hide resolved
styles/admin/Layout.module.scss Outdated Show resolved Hide resolved
components/admin/SideNav.tsx Outdated Show resolved Hide resolved
@mike2ox mike2ox added the enhancement New feature or request label Jan 30, 2023
@mike2ox mike2ox added this to the 코딩 run!! milestone Jan 30, 2023
@raehy19 raehy19 force-pushed the Feat/프론트_관리자_페이지_레이아웃_생성_#621 branch from 7121196 to 349a7eb Compare January 30, 2023 10:21
tamagoyakii
tamagoyakii approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@tamagoyakii tamagoyakii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

드디어 관리자 페이지가 만들어지네요!!! 너무 감격적입니다 ㅠ ㅠ 화이팅!!!

Wilbur0306
Wilbur0306 approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@Wilbur0306 Wilbur0306 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

관리자 페이지의 좌측 내비게이션 바에 각 카테고리들을 선택하였을 때, 내비게이션 바가 들어가면서 선택한 카테고리의 페이지만 보여지게끔 하면 더 좋을 것 같아요! 만드시느라 수고 많으셨습니당!

42sungwook
42sungwook approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@42sungwook 42sungwook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 없어보입니다 고생하셨어요! 혹시 이미지 파일은 어떤식으로 다운받으신거에요?? 캡쳐하신건가요?

@raehy19
Copy link
Contributor Author

raehy19 commented Jan 31, 2023

문제 없어보입니다 고생하셨어요! 혹시 이미지 파일은 어떤식으로 다운받으신거에요?? 캡쳐하신건가요?

네비게이션 바 로고 피그마에서 추출한 이미지 파일 쓰려다가 프로젝트가 원래 react-icons 쓰고 있어서 아이콘 import해서 썼습니다 !

@raehy19 raehy19 merged commit 25f4c8f into main Jan 31, 2023
@raehy19 raehy19 deleted the Feat/프론트_관리자_페이지_레이아웃_생성_#621 branch February 3, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike2ox mike2ox mike2ox left review comments

@42sungwook 42sungwook 42sungwook approved these changes

@Wilbur0306 Wilbur0306 Wilbur0306 approved these changes

@tamagoyakii tamagoyakii tamagoyakii approved these changes

Assignees

@raehy19 raehy19

Labels
enhancement New feature or request
Projects
No open projects
🍌 Version 2 - Frontend
Status: ✅ Done
Milestone
코딩 run!!
Development

Successfully merging this pull request may close these issues.
5 participants
@raehy19 @mike2ox @tamagoyakii @Wilbur0306 @42sungwook