Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] update tsconfig #614

Merged
merged 2 commits into from
Jan 30, 2023
Merged

[Fix] update tsconfig #614

merged 2 commits into from
Jan 30, 2023

Conversation

mike2ox
Copy link
Contributor

@mike2ox mike2ox commented Jan 19, 2023 •
edited
Loading

๐Ÿ“Œ ๊ฐœ์š”

  • tsconfig ์„ค์ • ๋ณ€๊ฒฝ

๐Ÿ’ป ์ž‘์—…์‚ฌํ•ญ

  • React component naming rule์„ ์ธ์‹ํ•˜๊ธฐ ์œ„ํ•ด typeRoot ์†์„ฑ์„ ์ ์šฉ
  • naming rule์— ๋งž๊ฒŒ InfScroll ์ปดํฌ๋„ŒํŠธ ์ด๋ฆ„ ์ˆ˜์ •

๊ด€๋ จ ์ด์Šˆ

@mike2ox mike2ox added the bug Something isn't working label Jan 19, 2023
@mike2ox mike2ox requested a review from a team January 19, 2023 05:50
@mike2ox mike2ox self-assigned this Jan 19, 2023
@mike2ox mike2ox requested review from raehy19, Wilbur0306, 42sungwook and imJusttheresd and removed request for a team and imJusttheresd January 19, 2023 05:50
@mike2ox mike2ox requested review from a team and imJusttheresd and removed request for a team January 20, 2023 06:44
raehy19
raehy19 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@raehy19 raehy19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค๋ฅ˜๋ฅผ ์ž˜ ์ฐพ์•„์ฃผ์…ง๋„ค์š” LGTM!!

@mike2ox mike2ox merged commit bea9b28 into main Jan 30, 2023
@mike2ox mike2ox deleted the Fix/update-tsconfig branch January 30, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raehy19 raehy19 raehy19 approved these changes

@Wilbur0306 Wilbur0306 Awaiting requested review from Wilbur0306 Wilbur0306 was automatically assigned from 42organization/fe_2nd

@42sungwook 42sungwook Awaiting requested review from 42sungwook 42sungwook was automatically assigned from 42organization/fe_2nd

@imJusttheresd imJusttheresd Awaiting requested review from imJusttheresd imJusttheresd was automatically assigned from 42organization/fe_2nd

Assignees

@mike2ox mike2ox

Labels
bug Something isn't working
Projects
No open projects
๐ŸŒ Version 2 - Frontend
Status: โœ… Done
Milestone
init project
Development

Successfully merging this pull request may close these issues.
2 participants
@mike2ox @raehy19