-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat 관리자 공고 등록 수정 템플릿 #1256 #1379
The head ref may contain hidden characters: "feat-\uAD00\uB9AC\uC790-\uACF5\uACE0-\uB4F1\uB85D-\uC218\uC815-\uD15C\uD50C\uB9BF-#1256"
Conversation
QuestionFormBuilder와 QuestionForm의 SingleCheck, MultiCheck 컴포넌트의 value를 |
@@ -198,7 +198,7 @@ export default function useRecruitmentEditInfo( | |||
const importRecruitmentInfo = async (recruitId: number) => { | |||
if (recruitId <= 0) return; | |||
try { | |||
const res = await instance.get('/recruitments/' + recruitId); | |||
const res = await instance.get('/admin/recruitments/' + recruitId); | |||
const data: Irecruit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
form: res.data.forms로 바꿔야 할 것 같아요(208번째 줄)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title: res.data.title, | ||
startDate: new Date(res.data.startDate), | ||
endDate: new Date(res.data.endDate), | ||
generation: res.data.generation, | ||
contents: res.data.contents, | ||
form: res.data.form, | ||
form: res.data.forms, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이것도 forms로 타입 통일해주는게 좋지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API 명세가 생성 수정에서는 form 조회시에는 forms여서 api 명세 통일했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 상세보기에서는 질문 창에 입력 막아두고 label 지우는 게 좋을 것 같습니다. 그리고 객관식 보기가 안보이는 것도 수정이 필요할 것 같아요. 등록이나 삭제는 잘 되는 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인이 늦어 죄송합니다... 작업하신 내용 모두 잘 동작하는 것 같습니다! 오타 하나만 수정해주세요 고생하셨습니다.👏
// contents: recruitmentEditInfo.contents, | ||
// form: recruitmentEditInfo.form, | ||
// }); | ||
alert('공고를 성공적을 생성하였습니다.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오타 수정해주세여!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!! 👍
📌 개요
API 연동 작업
💻 작업사항
TODO :
✅ 변경로직