Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
izone00
reviewed
Mar 20, 2024
izone00
reviewed
Mar 20, 2024
izone00
reviewed
Mar 20, 2024
contemplation-person
approved these changes
Mar 20, 2024
izone00
reviewed
Mar 20, 2024
izone00
reviewed
Mar 20, 2024
izone00
reviewed
Mar 20, 2024
|
|
||
| useEffect(() => { | ||
| if (partyPenalty) { | ||
| setIsUpdateMode(true); |
There was a problem hiding this comment.
이것도 불필요할 것 같아요
state의 초기값으로 !!partyPenalty 넣던지 아니면 그냥 일반 변수로 해도 될것 같아요
There was a problem hiding this comment.
useState을 쓰는게 더 직관적이고 이해하기 쉬운것같은데 사용하는 이유는 밑에 변경인지 추가인지 판별하려고 넣은거라
There was a problem hiding this comment.
useState쓰는건 상관없는데 이걸 useEffect에서 설정할 필요가 없을것 같아요
그냥 초기값을 설정할때 바로 넣어줄 수 있지않나요?
!!partyPenalty 나
partyPenalty ? true : false 같은 방식으로
izone00
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
💻 작업사항
✅ 변경로직