-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 공고 리스트 화면 #1273
The head ref may contain hidden characters: "feat/1257-feat-\uACF5\uACE0-\uB9AC\uC2A4\uD2B8-\uD654\uBA74"
[Feat] 공고 리스트 화면 #1273
Conversation
공통 레이아웃 디자인 적용을 위함
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다. recruit 메인화면(공고 존재할 때)에도 홈이나 뒤로가기 버튼이 있으면 좋을 것 같아요. 고생하셨습니다! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엄청 깔끔해졌네요 👍
className: styles.listItemTextPrimary, | ||
}} | ||
secondary={ | ||
dateToString(new Date(recruit.startDate)) + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dateToString 에서 전체적으로 padStart(2, '0') 추가해주면 좋을 것 같아요!
지금은 2024-3-11 이런식으로 나와서 조금 어색해보이네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오옹 좋은생각이네요!! 요거 수정사항은 바로 뒤 PR인 #1275 에다가 반영해둘게요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 하나 남겼는데 그것만 확인 해주세요! 고생 많으셨습니다😄
📌 개요
💻 작업사항
자잘한 변경사항..
recruitLayout
에 있던 불필요한 div 태그 삭제StickyHeader
를 따로 컴포넌트로 분리하고, 디자인(너비, z-index)을 수정했습니다.recruitLayout
flex 배치 수정StickyHeader
를 적용했습니다.공고 리스트
✅ 변경로직