Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 토너먼트 점수 입력 모달 #1135 #1139

Merged
merged 3 commits into from
Dec 7, 2023
Merged

[Feat] 토너먼트 점수 입력 모달 #1135 #1139

merged 3 commits into from
Dec 7, 2023

Conversation

greatSweetMango
Copy link
Collaborator

📌 개요

  • 토너먼트 점수 입력 모달이 작동할 수 있도록 추가했습니다.

💻 작업사항

  • 기존 MatchMode로 사용되던 mode 를 GameMode로 수정했습니다.

✅ 변경로직

@greatSweetMango greatSweetMango added enhancement New feature or request user 일반 사용자가 사용하는 서비스에서 발생한 issue labels Dec 6, 2023
@greatSweetMango greatSweetMango added this to the 42gg-5th-fe milestone Dec 6, 2023
@greatSweetMango greatSweetMango requested a review from a team December 6, 2023 10:52
@greatSweetMango greatSweetMango self-assigned this Dec 6, 2023
@greatSweetMango greatSweetMango linked an issue Dec 6, 2023 that may be closed by this pull request
[Feat] 토너먼트 점수입력 모달 제작 #1135
Closed
2 tasks
Clearsu
Clearsu approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@Clearsu Clearsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

점수입력 모달을 제네릭하게 쓸 수 있게 되어 기쁘네요!!

@greatSweetMango greatSweetMango merged commit 134387b into main Dec 7, 2023
1 check passed
@greatSweetMango greatSweetMango deleted the feat/토너먼트-점수입력-모달-제작-#1135 branch December 7, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clearsu Clearsu Clearsu approved these changes

Assignees

@greatSweetMango greatSweetMango

Labels
enhancement New feature or request user 일반 사용자가 사용하는 서비스에서 발생한 issue
Projects
42gg-5th-fe
Status: Done
Milestone
42gg-5th-fe
Development

Successfully merging this pull request may close these issues.

[Feat] 토너먼트 점수입력 모달 제작
2 participants
@greatSweetMango @Clearsu