Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #188: Make BeanProperty repeatable #206

Conversation

marcus-talbot42
Copy link
Contributor

  • Made BeanProperty repeatable.
  • Added BeanProperty#targets, allowing users to specify which mappings the specified BeanProperty should apply to.
  • Compatibility with existing usages of the BeanProperty-annotation.

Closes: #188

@marcus-talbot42 marcus-talbot42 self-assigned this Jul 13, 2024
@marcus-talbot42 marcus-talbot42 force-pushed the fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results branch 2 times, most recently from 74e2a58 to 74d5f23 Compare July 19, 2024 10:51
@marcus-talbot42 marcus-talbot42 force-pushed the fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results branch from 481fe08 to 3aa6715 Compare July 26, 2024 05:44
@marcus-talbot42 marcus-talbot42 force-pushed the fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results branch from 3aa6715 to ffa2420 Compare August 2, 2024 15:00
@marcus-talbot42 marcus-talbot42 force-pushed the fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results branch 3 times, most recently from 82e4e6b to 9c3fe07 Compare August 5, 2024 11:08
- Made BeanProperty repeatable.
- Added BeanProperty#targets, allowing users to specify which mappings
the specified BeanProperty should apply to.
- Compatibility with existing usages of the BeanProperty-annotation.

Closes: #188
@marcus-talbot42 marcus-talbot42 force-pushed the fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results branch from 9c3fe07 to aed96e7 Compare August 5, 2024 11:11
Copy link
Contributor

@TimQuist TimQuist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puur gekeken naar syntax etc, internals van beanmapper zelf zijn sowieso nieuw voor mij

@marcus-talbot42 marcus-talbot42 merged commit 2b0e3c3 into master Aug 6, 2024
0 of 2 checks passed
@marcus-talbot42 marcus-talbot42 deleted the fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results branch August 6, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@BeanProperty-annotation causes issues in mapping of Form to multiple types of Results.
3 participants