-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #188: Make BeanProperty repeatable #206
Merged
marcus-talbot42
merged 1 commit into
master
from
fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results
Aug 6, 2024
Merged
Fix #188: Make BeanProperty repeatable #206
marcus-talbot42
merged 1 commit into
master
from
fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcus-talbot42
force-pushed
the
fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results
branch
2 times, most recently
from
July 19, 2024 10:51
74e2a58
to
74d5f23
Compare
robert-bor
reviewed
Jul 24, 2024
src/main/java/io/beanmapper/core/inspector/BeanPropertySelector.java
Outdated
Show resolved
Hide resolved
marcus-talbot42
force-pushed
the
fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results
branch
from
July 26, 2024 05:44
481fe08
to
3aa6715
Compare
marcus-talbot42
force-pushed
the
fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results
branch
from
August 2, 2024 15:00
3aa6715
to
ffa2420
Compare
TimQuist
reviewed
Aug 5, 2024
src/main/java/io/beanmapper/core/inspector/BeanPropertySelector.java
Outdated
Show resolved
Hide resolved
marcus-talbot42
force-pushed
the
fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results
branch
3 times, most recently
from
August 5, 2024 11:08
82e4e6b
to
9c3fe07
Compare
- Made BeanProperty repeatable. - Added BeanProperty#targets, allowing users to specify which mappings the specified BeanProperty should apply to. - Compatibility with existing usages of the BeanProperty-annotation. Closes: #188
marcus-talbot42
force-pushed
the
fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results
branch
from
August 5, 2024 11:11
9c3fe07
to
aed96e7
Compare
TimQuist
approved these changes
Aug 6, 2024
TimQuist
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puur gekeken naar syntax etc, internals van beanmapper zelf zijn sowieso nieuw voor mij
marcus-talbot42
deleted the
fix/188-@BeanProperty-annotation-causes-issues-in-mapping-of-form-to-multiple-types-of-Results
branch
August 6, 2024 08:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #188