test: required status checks on main for release workflow #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The terraform .gitignore template is not required in this repository.
When semantic-release pushes to main, the previous commit messages included `[skip ci]` so `required_status_checks` stayed in a pending state. This has been removed from the commit message so workflows are triggered. A generic workflow has been added for the `Validate PR title` workflow to ensure this check also runs successfully on pushes to main.
|
This does not work. Checks running on main, with the same name as the required check, still results in the error with admin permissions removed: |
chris3ware
changed the title
chris3ware
added a commit
that referenced
this pull request
Mar 3, 2023
Currently semantic-release runs on pushes to main to bump the release version and update the CHANGELOG. It uses the 3ware-release app for authentication - which is permitted to bypass pull requests. However, due to the required status checks assigned to main branch's protection rule, the app requires Administrator permissions to bypass the checks. There are number of long running discussions requesting a *skip checks* feature for this type of workflow: community/community#13836 GitHub's documentation does provide a solution for **Handling Skipped But Required Checks**: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks > You can fix this by creating a generic workflow, with the same name, that will return true in any case similar to the workflow below This pull request removes the `[skip ci]` syntax from semantic-releases commit message. Generic workflows for the pull request title validation and lint workflows have also been added - as suggested in GitHub's docs. Admin permissions will be removed from the application for testing the new workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently semantic-release runs on pushes to main to bump the release version and update the CHANGELOG. It uses the 3ware-release app for authentication - which is permitted to bypass pull requests. However, due to the required status checks assigned to main branch's protection rule, the app requires Administrator permissions to bypass the checks.
There are number of long running discussions requesting a skip checks feature for this type of workflow:
community/community#13836
GitHub's documentation does provide a solution for Handling Skipped But Required Checks: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks
This pull request removes the
[skip ci]syntax from semantic-releasescommit message.
Generic workflows for the pull request title validation and lint workflows have
also been added - as suggested in GitHub's docs.
Admin permissions will be removed from the application for testing the new workflow.