Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapp1 83 btn bugfix #61

Merged
merged 4 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@3um-group/atomic-sdk",
"version": "1.0.15",
"version": "1.0.16",
"main": "dist/index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
Expand Down
2 changes: 1 addition & 1 deletion src/components/molecules/sidebar/Sidebar.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState } from 'react';
import React from 'react';
import { Meta, StoryFn } from '@storybook/react';
import Sidebar, { SidebarProps } from './Sidebar';

Expand Down
5 changes: 2 additions & 3 deletions src/components/molecules/sidebar/Sidebar.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React, { useEffect } from 'react';
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import { faGear } from '@fortawesome/free-solid-svg-icons';
import { Button } from '../../atoms';

export interface SidebarProps {
children: React.ReactNode;
Expand All @@ -14,8 +13,8 @@
<div className="drawer">
<input id="my-drawer" type="checkbox" className="drawer-toggle" />
<div className="drawer-content">
<label htmlFor="my-drawer" className="drawer-button">
<Button><FontAwesomeIcon icon={faGear} /></Button>
<label htmlFor="my-drawer" className="btn drawer-button">
<FontAwesomeIcon icon={faGear} />

Check failure on line 17 in src/components/molecules/sidebar/Sidebar.tsx

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/components/molecules/sidebar/Sidebar.tsx#L17

Unsafe assignment of an error typed value.
</label>
</div>
<div className="drawer-side">
Expand Down