Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💣🐒 Reduce webpackers' config monkey-patching and use v5 default #3275

Closed
wants to merge 4 commits into from
Closed

💣🐒 Reduce webpackers' config monkey-patching and use v5 default #3275

wants to merge 4 commits into from

Conversation

josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Mar 22, 2023 •
edited
Loading

⚠️ IMPORTANT NOTE:
The main problem about upgrading webpacker and webpack is that at some point we stopped using the default configuration. Now webpacker 6 diverges too much, specially because it now supports webpack 5 and a lot changes there.

This PR removes some "tech-debt" related to our webpack configuration. There are more to come.

Ran webpacker install to "re-install" all default files and configs and then cleaned up everything so that we have a standard webpacker installation. This way the upgrade to v6 and later shakapacker will happen smoothly.

@josemigallas josemigallas self-assigned this Mar 22, 2023
@josemigallas josemigallas requested a review from a team March 22, 2023 15:57
@josemigallas josemigallas changed the title Reduce 🐒 webpackers' config monkey-patching 💣🐒 Reduce webpackers' config monkey-patching Mar 22, 2023
akostadinov
akostadinov reviewed Mar 22, 2023
View reviewed changes
.babelrc Outdated Show resolved Hide resolved
akostadinov
akostadinov previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@akostadinov akostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and nitpicks that you may or may not ignore, at your discretion. This is a huge improvement!

akostadinov
akostadinov previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@akostadinov akostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another nit pick but looks good!

.postcssrc.yml Outdated Show resolved Hide resolved
@josemigallas josemigallas changed the title 💣🐒 Reduce webpackers' config monkey-patching 💣🐒 Reduce webpackers' config monkey-patching and use v5 default Mar 24, 2023
jlledom
jlledom reviewed Mar 24, 2023
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
app/javascript/src/Stats/buyer/stats_application.jsx Show resolved Hide resolved
bin/webpack-dev-server Outdated Show resolved Hide resolved
babel.config.js Outdated Show resolved Hide resolved
config/initializers/content_security_policy.rb Outdated Show resolved Hide resolved
config/webpacker.yml Show resolved Hide resolved
config/webpacker.yml Outdated Show resolved Hide resolved
@josemigallas josemigallas force-pushed the reduce_webpack_config branch 2 times, most recently from cde9c2b to 5d5e5ef Compare March 24, 2023 17:56
jlledom
jlledom reviewed Mar 28, 2023
View reviewed changes
Copy link
Contributor

@jlledom jlledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not upgrading @types/jest? Does it do any harm?

@josemigallas
Copy link
Contributor Author

Why not upgrading @types/jest? Does it do any harm?

It's not directly related to webpacker and I'd like to upgrade the whole jest suite in another PR.

jlledom
jlledom previously approved these changes Apr 11, 2023
View reviewed changes
@josemigallas josemigallas force-pushed the reduce_webpack_config branch 3 times, most recently from 885909a to 04e6976 Compare April 18, 2023 09:21
@josemigallas josemigallas marked this pull request as draft May 4, 2023 16:39
@josemigallas josemigallas mentioned this pull request May 4, 2023
Merged
@josemigallas
Copy link
Contributor Author

This is not looking good. CI won't compile because OOM, the bundle is bigger and styles are not injected causing some tests to fail.
I'm gonna hold this for now and try upgrade directly to shakapacker, which has direct support over their Slack channel and is supposed to fix most of this stuff.

@mayorova mayorova deleted the reduce_webpack_config branch October 3, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akostadinov akostadinov akostadinov left review comments

@jlledom jlledom jlledom left review comments

Assignees

@josemigallas josemigallas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemigallas @akostadinov @jlledom