store git commit in the lockfile #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with a copy that is going to store git commit to workaround https://github.com/luarocks/luarocks/issues/739<D-3>
so we don't have to clone all git repositories
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Oct 31, 2017
hallelujah
reviewed
Oct 31, 2017
| local command = {fs.Q(git_cmd), "clone", depth or "--depth=1", rockspec.source.url, module} | ||
| local tag_or_branch = rockspec.source.tag or rockspec.source.branch | ||
| -- If the tag or branch is explicitly set to "master" in the rockspec, then | ||
| -- we can avoid passing it to Git since it's the default. |
There was a problem hiding this comment.
I am not really sure of that
Can’t we choose a default branch in GH and when we clone it will be this branch that will be default?
https://stackoverflow.com/questions/18726037/what-determines-default-branch-after-git-clone
Still depends on the version of git >1.8.5
Maybe safer/simpler to add the branch?
Also if you know what you are cloning you can use —depth=1 So you are not pulling the whole history of the branch
Or maybe using this https://stackoverflow.com/a/3489576
There was a problem hiding this comment.
This code is copied from luarocks itself with no changes. Honestly I don't really care much what it does because rover in later commits overrides it to just clone whole repo and do a reset.
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Nov 2, 2017
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Nov 2, 2017
* we need to use some templating to customize nginx directives not
accessible from Lua code (like buffer sizes, etc.)
* using liquid templating language
* introduce `bin/cli` that is a main entrypoint to:
- configure paths to load local code and dependencies
- execute lua cli code
* `bin/apicast` is now slim perl wrapper to setup paths,
because it has access to current working folder and
ritch stdlib for working with filesystem and env variables
* introduce concept of an environment,
so each can have own config, like rails
* use latest rover and lock scm dependencies
3scale/lua-rover#2
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Nov 2, 2017
* we need to use some templating to customize nginx directives not
accessible from Lua code (like buffer sizes, etc.)
* using liquid templating language
* introduce `bin/cli` that is a main entrypoint to:
- configure paths to load local code and dependencies
- execute lua cli code
* `bin/apicast` is now slim perl wrapper to setup paths,
because it has access to current working folder and
ritch stdlib for working with filesystem and env variables
* introduce concept of an environment,
so each can have own config, like rails
* use latest rover and lock scm dependencies
3scale/lua-rover#2
update changelog
mikz
added a commit
to 3scale/APIcast
that referenced
this pull request
Nov 6, 2017
* we need to use some templating to customize nginx directives not
accessible from Lua code (like buffer sizes, etc.)
* using liquid templating language
* introduce `bin/cli` that is a main entrypoint to:
- configure paths to load local code and dependencies
- execute lua cli code
* `bin/apicast` is now slim perl wrapper to setup paths,
because it has access to current working folder and
ritch stdlib for working with filesystem and env variables
* introduce concept of an environment,
so each can have own config, like rails
* use latest rover and lock scm dependencies
3scale/lua-rover#2
update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1
we need to lock the git reference when getting source code from git
this overrides installed luarocks git strategy with custom version, it is pretty evil but works
also it stores custom property in the rockspec so it can verify it after dependencies were installed
for the record, the new format with old rover will crash like: https://circleci.com/gh/3scale/apicast/1495
Failed to parse constraint '2.0.rc12-1|' with error: Encountered bad constraint operator: 'nil' in '|'