Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when downloading configs that contain Liquid (portal endpoint with path) #847

Merged
merged 3 commits into from
Aug 20, 2018

Conversation

davidor
Copy link
Contributor

@davidor davidor commented Aug 20, 2018

Closes #828

This should have been part of #845 . It's the same bug but triggered when THREESCALE_PORTAL_ENDPOINT has a path.

@davidor davidor requested a review from a team as a code owner August 20, 2018 15:45
@davidor davidor force-pushed the fix-portal-endpoint-with-path-and-liquid-confs branch from f07f8f7 to 94c28b6 Compare August 20, 2018 15:46
Copy link
Contributor

@mikz mikz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidor davidor force-pushed the fix-portal-endpoint-with-path-and-liquid-confs branch from ee26c3c to 1d1d260 Compare August 20, 2018 15:54
@davidor
Copy link
Contributor Author

davidor commented Aug 20, 2018

Added a changelog entry and deleted a ---ONLY that I left in one of the integration tests.

@davidor davidor merged commit b6133cd into master Aug 20, 2018
@davidor davidor deleted the fix-portal-endpoint-with-path-and-liquid-confs branch August 20, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants