Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt Docker development env to namespace changes #493

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Adapt Docker development env to namespace changes #493

merged 1 commit into from
Nov 21, 2017

Conversation

davidor
Copy link
Contributor

@davidor davidor commented Nov 21, 2017

This PR simply adapts the paths used by the development Docker to the new structure introduced in #486

mikz
mikz approved these changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@mikz mikz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We could add it as another task in CircleCI to verify it keeps working if you want.

@davidor
Copy link
Contributor Author

davidor commented Nov 21, 2017

Right. I'll add that in a future PR.

@davidor davidor merged commit b3a885c into master Nov 21, 2017
@davidor davidor deleted the adapt-dockerfile-devel-to-namespace-changes branch November 21, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikz mikz mikz approved these changes

Assignees

@davidor davidor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidor @mikz