[resty.resolver] properly cache queries with scope #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
resty-resolver-cache-search
branch
3 times, most recently
from
1507075
to
5bad24d
Compare
queries made by scope search would not be cached properly as the cache would ask only for the query without the scope so now try to retrive from cache during each lookup step
mikz
force-pushed
the
resty-resolver-cache-search
branch
from
5bad24d
to
342d6d0
Compare
mikz
force-pushed
the
resty-resolver-cache-search
branch
6 times, most recently
from
acbb59e
to
d2568e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queries made by scope search would not be cached properly
as the cache would ask only for the query without the scope
so now try to retrive from cache during each lookup step