Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy: IpCheck default deny. #1273

Merged
merged 1 commit into from
May 31, 2021
Merged

Conversation

eloycoto
Copy link
Contributor

Right now, when the IP cannot be retrieved on the IPCheck policy, the
request is accepted, but we cannot ensure the origin, so we should deny
always by default, and if the verdict is allowed, continue with the
request.

Fix THREESCALE-7076
Fix THREESCALE-7075

Signed-off-by: Eloy Coto [email protected]

@eloycoto eloycoto requested a review from a team as a code owner May 19, 2021 20:04
Right now, when the IP cannot be retrieved on the IPCheck policy, the
request is accepted, but we cannot ensure the origin, so we should deny
always by default, and if the verdict is allowed, continue with the
request.

Fix THREESCALE-7076
Fix THREESCALE-7075

Signed-off-by: Eloy Coto <[email protected]>
@eloycoto eloycoto merged commit 5f7b751 into 3scale:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants