Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define resolver in nginx config #488

Closed
mikz opened this issue Nov 21, 2017 · 0 comments · Fixed by #508
Closed

Define resolver in nginx config #488

mikz opened this issue Nov 21, 2017 · 0 comments · Fixed by #508
Assignees
@mikz

Comments

@mikz
Copy link
Contributor

mikz commented Nov 21, 2017

It is possible that custom policies will want to use cosockets with internal nginx name resolution like nmasse-itix/apicast-logger#2 and using our wrappers would be too verbose.

So adding detected nameservers to the generated nginx config should provide sane default for contributors writing policies as they could use ngx.socket.tcp:connect with a name instead of just IP address or using our wrapper.
This was referenced Nov 21, 2017
Open
Merged
mikz added a commit that referenced this issue Nov 24, 2017
@mikz
[nginx] configure nginx resolver
3e32e24 
closes #488
mikz added a commit that referenced this issue Nov 24, 2017
@mikz
[nginx] configure nginx resolver
9bf402f 
closes #488
mikz added a commit that referenced this issue Nov 27, 2017
@mikz
[nginx] configure nginx resolver
6a57d15 
closes #488
mikz added a commit that referenced this issue Nov 28, 2017
@mikz
[nginx] define resolver directive in the config
85418c5 
so cosockets use internal resolver and don't have to
go through APIcast resolver.

Closes #488
mikz added a commit that referenced this issue Nov 28, 2017
@mikz
[nginx] define resolver directive in the config
e226d0c 
so cosockets use internal resolver and don't have to
go through APIcast resolver.

Closes #488
mikz added a commit that referenced this issue Nov 28, 2017
@mikz
[nginx] define resolver directive in the config
69da7e9 
so cosockets use internal resolver and don't have to
go through APIcast resolver.

Closes #488
@mikz mikz mentioned this issue Nov 28, 2017
Merged
@ghost ghost assigned mikz Nov 28, 2017
@ghost ghost added the B-current label Nov 28, 2017
mikz added a commit that referenced this issue Nov 28, 2017
@mikz
[nginx] define resolver directive in the config
c26e3f2 
so cosockets use internal resolver and don't have to
go through APIcast resolver.

Closes #488
mikz added a commit that referenced this issue Nov 28, 2017
@mikz
[nginx] define resolver directive in the config
d83daa9 
so cosockets use internal resolver and don't have to
go through APIcast resolver.

Closes #488
@mikz mikz closed this as completed in #508 Nov 28, 2017
@ghost ghost removed the B-current label Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikz mikz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[nginx] define resolver directive in the config 3scale/APIcast
1 participant
@mikz