policy: avoid exposing PHASES

The module is designed so its users call phases() instead.

apicast/src/executor.lua

@@ -15,7 +15,7 @@ local _M = { }
 local mt = { __index = _M }
 
 -- forward all policy methods to the policy chain
-for _,phase in policy:phases() do
+for _,phase in policy.phases() do
     _M[phase] = function(self, ...)
         return self.policy_chain[phase](self.policy_chain, self:context(phase), ...)
     end

apicast/src/policy.lua

@@ -1,10 +1,10 @@
-local _M = {
-    PHASES = {
-        'init', 'init_worker',
-        'rewrite', 'access', 'balancer',
-        'header_filter', 'body_filter',
-        'post_action',  'log'
-    }
+local _M = { }
+
+local PHASES = {
+    'init', 'init_worker',
+    'rewrite', 'access', 'balancer',
+    'header_filter', 'body_filter',
+    'post_action',  'log'
 }
 
 local setmetatable = setmetatable
@@ -28,15 +28,15 @@ function _M.new(name, version)
         return setmetatable({}, mt)
     end
 
-    for _, phase in _M:phases() do
+    for _, phase in _M.phases() do
         policy[phase] = noop
     end
 
     return policy
 end
 
-function _M:phases()
-    return ipairs(self.PHASES)
+function _M.phases()
+    return ipairs(PHASES)
 end
 
 return _M

apicast/src/policy/local_chain.lua

@@ -16,7 +16,7 @@ local function build_chain(context)
 end
 
 -- forward all policy methods to the policy chain
-for _, phase in policy:phases() do
+for _, phase in policy.phases() do
   _M[phase] = function(_, context, ...)
     local policy_chain = find_policy_chain(context)
 

apicast/src/policy/phase_logger.lua

@@ -5,7 +5,7 @@
 local policy = require('policy')
 local _M = policy.new('Phase logger')
 
-for _, phase in policy:phases() do
+for _, phase in policy.phases() do
   _M[phase] = function() ngx.log(ngx.DEBUG, 'running phase: ', phase) end
 end
 

apicast/src/policy_chain.lua

@@ -82,7 +82,7 @@ local function call_chain(phase_name)
     end
 end
 
-for _,phase in policy:phases() do
+for _,phase in policy.phases() do
     _M[phase] = call_chain(phase)
 end
 

spec/policy_spec.lua

@@ -31,7 +31,7 @@ describe('policy', function()
     it('defines a method for each of the nginx phases; they do nothing by default', function()
       local my_policy = policy.new('custom_authorizer')
 
-      for _, phase in policy:phases() do
+      for _, phase in policy.phases() do
         -- To be precise, we should check that the function is defined, returns
         -- nil, and it does not have any side-effects. Checking the latter is
         -- complicated so we'll leave it for now.
@@ -51,7 +51,7 @@ describe('policy', function()
   describe('.phases', function()
     it('returns the nginx phases where policies can run, sorted by order of execution', function()
       local res = {}
-      for _, phase in policy:phases() do
+      for _, phase in policy.phases() do
         table.insert(res, phase)
       end