update service: only include system_name when specified in options #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
approved these changes
Oct 31, 2018
|
|
||
| def initialize (source, source_service_id, destination, target_service_id, insecure) | ||
| def initialize (source, source_service_id, destination, target_service_id, insecure, system_name) |
There was a problem hiding this comment.
This starts to be a bit too much.
There was a problem hiding this comment.
Sure!
refactor is coming with new features of the CLI framework :)
| def target_service_params(source) | ||
| source.select { |k, v| Commands.service_valid_params.include?(k) && v } | ||
| target_service = source.select do |k, v| | ||
| Commands.service_valid_params.include?(k) \ |
There was a problem hiding this comment.
Wouldn't it be nicer to provider service_valid_update_params that does not have the system_name ?
There was a problem hiding this comment.
I was thinking on that too. But system_name is needed sometimes, and it is a valid attribute of the service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating service from source to destination, source
system_nameis being sent to update destinationsystem_name. This is a problem when updating services within the same tenant, since you would get the following error from API:{"system_name": ["has already been taken"]}The fix is: do not try to overwrite system name, unless specified using command's new optional argument with option
-t, --target_system_name