Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking change] mapping rules will be replaced instead of adding missing rules #308

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

eguzki
Copy link
Member

@eguzki eguzki commented Jun 23, 2021

@eguzki eguzki requested a review from miguelsorianod June 23, 2021 12:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021

Codecov Report

Merging #308 (90f1e90) into main (95d37ca) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 90f1e90 differs from pull request most recent head eb45a24. Consider uploading reports for the commit eb45a24 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   96.22%   96.24%   +0.02%     
==========================================
  Files         296      298       +2     
  Lines       14527    14560      +33     
==========================================
+ Hits        13978    14013      +35     
+ Misses        549      547       -2     
Impacted Files Coverage Δ
...e_toolbox/commands/product_command/copy_command.rb 100.00% <ø> (ø)
...toolbox/commands/product_command/import_command.rb 98.33% <ø> (ø)
...unit/commands/backend_command/copy_command_spec.rb 100.00% <ø> (ø)
...e_toolbox/commands/backend_command/copy_command.rb 100.00% <100.00%> (ø)
..._command/copy_command/delete_mapping_rules_task.rb 100.00% <100.00%> (ø)
...lbox/commands/backend_command/copy_command/task.rb 100.00% <100.00%> (+3.03%) ⬆️
...product_command/copy_command/copy_backends_task.rb 100.00% <100.00%> (ø)
...and/copy_command/delete_mapping_rules_task_spec.rb 100.00% <100.00%> (ø)
...t_command/openapi/update_service_oidc_conf_step.rb 94.73% <0.00%> (-0.27%) ⬇️
spec/unit/entities/service_spec.rb 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d37ca...eb45a24. Read the comment docs.

@eguzki eguzki force-pushed the fix-delete-old-mapping-rules branch from dccf0dd to 295f06a Compare June 29, 2021 16:35
@eguzki
Copy link
Member Author

eguzki commented Jun 30, 2021

ready for review @miguelsorianod

@eguzki eguzki force-pushed the fix-delete-old-mapping-rules branch 2 times, most recently from 94cb1a3 to eb45a24 Compare July 2, 2021 08:57
@eguzki eguzki force-pushed the fix-delete-old-mapping-rules branch from eb45a24 to 7b6b02f Compare July 6, 2021 11:57
@eguzki eguzki merged commit 2b78c07 into main Jul 7, 2021
@eguzki eguzki deleted the fix-delete-old-mapping-rules branch July 7, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old mapping rules aren't replaced when importing a product
3 participants